Skip to content

[Redis Enterprise]Add dimension fields to node datastream for TSDB su… - #8091

Merged
ritalwar merged 8 commits into
elastic:mainfrom
ritalwar:redisenterprise_tsdb_node_dimension_6268
Nov 18, 2023
Merged

[Redis Enterprise]Add dimension fields to node datastream for TSDB su…#8091
ritalwar merged 8 commits into
elastic:mainfrom
ritalwar:redisenterprise_tsdb_node_dimension_6268

Conversation

@ritalwar

@ritalwar ritalwar commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

  • This PR adds dimensions for node datastream of Redis Enterprise to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots
@ritalwar
ritalwar requested a review from a team as a code owner October 4, 2023 14:02
@ritalwar ritalwar mentioned this pull request Oct 4, 2023
Closed
11 tasks
@elasticmachine

elasticmachine commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-16T06:58:36.401+0000

  • Duration: 15 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👎 -47.531
Lines 100.0% (0/0) 💚 17.607
Conditionals 100.0% (0/0) 💚
@ritalwar
ritalwar requested a review from agithomas October 9, 2023 06:29
agithomas
agithomas approved these changes Oct 9, 2023
View reviewed changes

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ritalwar ritalwar added the enhancement New feature or request label Nov 1, 2023
@ritalwar ritalwar mentioned this pull request Nov 10, 2023
Merged
4 tasks
@ritalwar

ritalwar commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

/test
harnish-crest-data
harnish-crest-data approved these changes Nov 17, 2023
View reviewed changes

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ritalwar
ritalwar merged commit 4132ad3 into elastic:main Nov 18, 2023
@elasticmachine

elasticmachine commented Nov 18, 2023

Copy link
Copy Markdown

Package redisenterprise - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=redisenterprise
@andrewkroh andrewkroh added the Integration:redisenterprise Redis Enterprise label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:redisenterprise Redis Enterprise

5 participants

@ritalwar @elasticmachine @agithomas @harnish-crest-data @andrewkroh