Skip to content

[TrendMicro VisionOne] Fix missing request in pipeline - #8160

Merged
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:trendmicro_request_err
Oct 13, 2023
Merged

[TrendMicro VisionOne] Fix missing request in pipeline#8160
kcreddy merged 1 commit into
elastic:mainfrom
kcreddy:trendmicro_request_err

Conversation

@kcreddy

@kcreddy kcreddy commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

The pipeline's uri_parts processor throws an error when trend_micro_vision_one.detection.request field is missing in the response. We have seen sample logs where this might happen. Certain categories of data such as BEHAVIORAL_VIOLATION, INTEGRITY_MONITORING_EVENT, APPLICATION_CONTROL_VIOLATION, FIREWALL_POLICY_VIOLATION etc. doesn't contain this field. Fixing this by adding a conditional.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/trend_micro_vision_one
elastic-package build && elastic-package stack up --version=8.11.0-SNAPSHOT -d -v --services=elasticsearch && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate

Related issues

Screenshots
@kcreddy kcreddy mentioned this pull request Oct 11, 2023
Merged
4 tasks
@kcreddy
kcreddy force-pushed the trendmicro_request_err branch from 09845de to d8c06b8 Compare October 11, 2023 05:39
@elasticmachine

elasticmachine commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T05:40:11.306+0000

  • Duration: 15 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 11, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.346
Classes 100.0% (3/3) 💚 3.346
Methods 95.652% (44/46) 👍 3.096
Lines 95.229% (1517/1593) 👍 6.822
Conditionals 100.0% (0/0) 💚
efd6
efd6 approved these changes Oct 11, 2023
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why these documents without request exist?
@kcreddy
kcreddy marked this pull request as ready for review October 11, 2023 05:59
@kcreddy
kcreddy requested a review from a team as a code owner October 11, 2023 05:59
@kcreddy

kcreddy commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

Do we know why these documents without request exist?

Hey @efd6, I'm checking with the user. #8083 (comment)
@kcreddy kcreddy self-assigned this Oct 11, 2023
@elasticmachine

elasticmachine commented Oct 11, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@kcreddy kcreddy added the bugfix Pull request that fixes a bug issue label Oct 11, 2023
@kcreddy

kcreddy commented Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

@efd6 let me know if you are okay with this user's explanation - #8083 (comment). I will proceed merging the PR. Thanks!
@efd6

efd6 commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

@kcreddy Thanks, that is fine with me.
@kcreddy
kcreddy merged commit 555a462 into elastic:main Oct 13, 2023
@elasticmachine

elasticmachine commented Oct 13, 2023

Copy link
Copy Markdown

Package trend_micro_vision_one - 1.12.2 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one
@kcreddy
kcreddy deleted the trendmicro_request_err branch February 7, 2025 08:37
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kcreddy
Fix missing request in pipeline (elastic#8160)
58fbb2d 
Certain categories of data such as BEHAVIORAL_VIOLATION, INTEGRITY_MONITORING_EVENT, APPLICATION_CONTROL_VIOLATION, FIREWALL_POLICY_VIOLATION etc. doesn't contain the field trend_micro_vision_one.detection.request in the response. Fixing this by adding a conditional on uri_parts processor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:trend_micro_vision_one TrendAI Vision One

4 participants

@kcreddy @elasticmachine @efd6 @bhapas