Skip to content

[Cloud Security] Assign default GCP account type - #8228

Merged
jeniawhite merged 2 commits into
elastic:mainfrom
jeniawhite:evgb-GCPAccountType
Oct 17, 2023
Merged

[Cloud Security] Assign default GCP account type#8228
jeniawhite merged 2 commits into
elastic:mainfrom
jeniawhite:evgb-GCPAccountType

Conversation

@jeniawhite

@jeniawhite jeniawhite commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

In order to have a working GCP integration, we are required to have an account type.
Older integrations did not have this value, this caused a breaking change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@jeniawhite
jeniawhite requested a review from a team as a code owner October 17, 2023 12:54
@jeniawhite jeniawhite changed the title [cloud_security_posture] Assign default GCP account type Oct 17, 2023
@jeniawhite jeniawhite added bug Something isn't working, use only for issues Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Oct 17, 2023
@elasticmachine

elasticmachine commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-17T12:56:30.655+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 17, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -66.463
Lines 100.0% (0/0) 💚 3.688
Conditionals 100.0% (0/0) 💚
@jeniawhite
jeniawhite merged commit 1c150f8 into elastic:main Oct 17, 2023
@elasticmachine

elasticmachine commented Oct 17, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.6.4-preview1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@jeniawhite jeniawhite mentioned this pull request Oct 18, 2023
Closed
4 tasks
jeniawhite added a commit to jeniawhite/integrations that referenced this pull request Oct 18, 2023
@jeniawhite
Revert "[Cloud Security] Assign default GCP account type (elastic#8228)"
9d78911 
This reverts commit 1c150f8.
@elasticmachine

elasticmachine commented Oct 19, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@jeniawhite
[Cloud Security] Assign default GCP account type (elastic#8228)
ccb6a94 
* Assign default GCP account type

* Fix preview and assign PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

4 participants

@jeniawhite @elasticmachine @oren-zohar @andrewkroh