Skip to content

[azure_metrics] add missing dimensions to the database_account datastream; fix typo in container_registry datastream - #8319

Merged
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:azure_database-account_add_missing_dimensions
Nov 6, 2023
Merged

[azure_metrics] add missing dimensions to the database_account datastream; fix typo in container_registry datastream#8319
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:azure_database-account_add_missing_dimensions

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Proposed commit message

  • add missing dimensions to the database_account datastream
  • fix typo in the fields definition of the container_registry datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@tetianakravchenko
add missing dimensions; fix typo
ca47d63 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
tetianakravchenko requested a review from a team as a code owner October 27, 2023 15:00
@tetianakravchenko
fix the pr link
bc285c0 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko mentioned this pull request Oct 27, 2023
Closed
@elasticmachine

elasticmachine commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-27T15:01:24.659+0000

  • Duration: 16 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 27, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -24.242
Lines 100.0% (32/32) 💚 4.054
Conditionals 100.0% (0/0) 💚
zmoog
zmoog approved these changes Oct 30, 2023
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tetianakravchenko
tetianakravchenko merged commit a537327 into elastic:main Nov 6, 2023
@elasticmachine

elasticmachine commented Nov 6, 2023

Copy link
Copy Markdown

Package azure_metrics - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=azure_metrics
@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:azure_metrics Azure Resource Metrics

4 participants

@tetianakravchenko @elasticmachine @zmoog @andrewkroh