Skip to content

[AlienVault OTC] Populate Related IP and Related Hash Fields - #8323

Merged
efd6 merged 7 commits into
elastic:mainfrom
MakoWish:ti_alienvault_related_fields
Dec 5, 2023
Merged

[AlienVault OTC] Populate Related IP and Related Hash Fields#8323
efd6 merged 7 commits into
elastic:mainfrom
MakoWish:ti_alienvault_related_fields

Conversation

@MakoWish

@MakoWish MakoWish commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please label this PR with one of the following labels, depending on the scope of your change:

  • Enhancement

Proposed commit message

The AlienVault OTX integration does not currently populate hash or IP values to related.hash and related.ip, respectively. This PR adds those values.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@MakoWish
MakoWish marked this pull request as ready for review October 27, 2023 17:01
@MakoWish
MakoWish requested a review from a team as a code owner October 27, 2023 17:01
@elasticmachine

elasticmachine commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T18:06:47.101+0000

  • Duration: 19 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6

efd6 commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Oct 30, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 96.0% (24/25) 👍 71.0
Lines 69.213% (308/445) 👎 -30.787
Conditionals 100.0% (0/0) 💚
bhapas
bhapas approved these changes Oct 30, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@MakoWish

MakoWish commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

I don't have permissions to merge, so if someone would be so kind. :-)
@botelastic

botelastic Bot commented Nov 29, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic Bot added the Stalled label Nov 29, 2023
@botelastic botelastic Bot removed the Stalled label Nov 29, 2023
@MakoWish

MakoWish commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

Would somebody please retest and merge this?
@efd6
efd6 merged commit cc5e245 into elastic:main Dec 5, 2023
@elasticmachine

elasticmachine commented Dec 5, 2023

Copy link
Copy Markdown

Package ti_otx - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=ti_otx
@andrewkroh andrewkroh added the Integration:ti_otx AlienVault OTX label Jul 22, 2024
@MakoWish
MakoWish deleted the ti_alienvault_related_fields branch February 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:ti_otx AlienVault OTX

5 participants

@MakoWish @elasticmachine @efd6 @bhapas @andrewkroh