Skip to content

[O11Y] [GCP Billing] Update Legacy metrics in GCP Billing overview dashboard - #8404

Merged
milan-elastic merged 5 commits into
elastic:mainfrom
milan-elastic:gcp-billing-convert-to-new-metric
Dec 22, 2023
Merged

[O11Y] [GCP Billing] Update Legacy metrics in GCP Billing overview dashboard#8404
milan-elastic merged 5 commits into
elastic:mainfrom
milan-elastic:gcp-billing-convert-to-new-metric

Conversation

@milan-elastic

@milan-elastic milan-elastic commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Update Legacy metric visualization to new metric in GCP Billing overview dashboard.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.1 itself.

How to test this PR locally

Related issues

Screenshots

Before migration
gcp-billing (1)

After migration

gcp-billing (2)

@milan-elastic
milan-elastic requested review from a team as code owners November 6, 2023 07:31
@milan-elastic milan-elastic self-assigned this Nov 6, 2023
@milan-elastic milan-elastic added enhancement New feature or request Integration:gcp Google Cloud Platform dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Nov 6, 2023
@elasticmachine

elasticmachine commented Nov 6, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-24T10:04:27.656+0000

  • Duration: 21 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 69
Skipped 0
Total 69

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 6, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115)
Lines 95.124% (1502/1579)
Conditionals 100.0% (0/0) 💚
@lalit-satapathy
lalit-satapathy requested a review from a user December 14, 2023 10:11
@lalit-satapathy

Copy link
Copy Markdown
Contributor

Adding @gpop63 for review.

@milan-elastic
milan-elastic force-pushed the gcp-billing-convert-to-new-metric branch from 0682118 to d3e61d2 Compare December 21, 2023 05:46
@milan-elastic
milan-elastic requested review from a team as code owners December 21, 2023 05:46
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@milan-elastic
milan-elastic merged commit 8c47e4d into elastic:main Dec 22, 2023
@elasticmachine

Copy link
Copy Markdown

Package gcp - 2.33.1 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:gcp Google Cloud Platform

6 participants