Skip to content

[O11y] [ SpringBoot] Support GC datastream on springboot 2.x with LTS JDK versions 11,17 and 21 - #8405

Merged
ali786XI merged 5 commits into
elastic:mainfrom
milan-elastic:springboot-lts-jdk-support
Nov 22, 2023
Merged

[O11y] [ SpringBoot] Support GC datastream on springboot 2.x with LTS JDK versions 11,17 and 21#8405
ali786XI merged 5 commits into
elastic:mainfrom
milan-elastic:springboot-lts-jdk-support

Conversation

@milan-elastic

@milan-elastic milan-elastic commented Nov 6, 2023 •
edited by shmsr
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Extends support for LTS JDK versions from only 8 to 8, 11,17, and 21 with the latest version of Springboot 2.7.17.

Related issues
@elasticmachine

elasticmachine commented Nov 6, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T06:06:41.958+0000

  • Duration: 19 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@milan-elastic
milan-elastic force-pushed the springboot-lts-jdk-support branch from 98e48bf to 92ea9bc Compare November 6, 2023 11:35
@elasticmachine

elasticmachine commented Nov 6, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.636
Classes 100.0% (3/3) 💚 3.636
Methods 100.0% (30/30) 💚 7.625
Lines 96.774% (300/310) 👍 8.144
Conditionals 100.0% (0/0) 💚
@milan-elastic milan-elastic self-assigned this Nov 7, 2023
@milan-elastic
milan-elastic marked this pull request as ready for review November 7, 2023 12:23
@milan-elastic
milan-elastic requested a review from a team as a code owner November 7, 2023 12:23
harnish-crest-data
harnish-crest-data approved these changes Nov 7, 2023
View reviewed changes

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
shmsr
shmsr requested changes Nov 7, 2023
View reviewed changes
Comment thread packages/spring_boot/_dev/build/docs/README.md Outdated
Comment thread packages/spring_boot/changelog.yml Outdated
milan-elastic and others added 3 commits November 8, 2023 13:07
@milan-elastic @shmsr
Update README.md
ae99726 
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@milan-elastic @shmsr
Update changelog.yml
674e48b 
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@milan-elastic
Update README.md
3a2ee3d
@milan-elastic
milan-elastic requested a review from shmsr November 8, 2023 07:49
@shmsr shmsr changed the title [O11y] [ SpringBoot] Support GC datastream on springboot 2.x with lts jdk version 11,17,21 Nov 10, 2023
@shmsr shmsr added the enhancement New feature or request label Nov 10, 2023
@shmsr

shmsr commented Nov 10, 2023

Copy link
Copy Markdown
Member

Just a reminder: PR description template tells you to label the PR with bug/enhancement/etc. and not write them in the PR description. Just the labeling with the right type of PR is enough. Like I have just labelled this PR as "enhancement" and removed the same from the description.
@ali786XI
ali786XI merged commit 7261c9e into elastic:main Nov 22, 2023
@elasticmachine

elasticmachine commented Nov 22, 2023

Copy link
Copy Markdown

Package spring_boot - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:spring_boot Spring Boot

6 participants

@milan-elastic @elasticmachine @shmsr @harnish-crest-data @andrewkroh @ali786XI