[Atlassian Confluence] Adding new pagination conditions - #8406
Merged
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
ShourieG
approved these changes
Nov 6, 2023
🌐 Coverage report
|
Member
Author
|
Resolving some issues with the params part of the new addition + adding more system tests so that it will finish instead of looping, as results are never 0. |
|
Package atlassian_confluence - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Currently the pagination settings specifically for atlassian cloud do not have a failure condition on pagination, and therefore ends up paginating forever.
There is a few ways to resolve this, I think maybe the best approach would have been to simply utilize the "next" link that is included in each response, as the "next" value is missing once there is no more results. This is done for the on-prem version of confluence (and other atlassian products like jira).
However to keep the state working as it is, I have added the failure condition instead, which also works just fine.
There should be some investigation into making the pagination smarter on these niche scenarios.
Checklist
changelog.ymlfile.