Skip to content

[Atlassian Confluence] Adding new pagination conditions - #8406

Merged
P1llus merged 5 commits into
elastic:mainfrom
P1llus:package_confluence_pagination
Nov 6, 2023
Merged

[Atlassian Confluence] Adding new pagination conditions#8406
P1llus merged 5 commits into
elastic:mainfrom
P1llus:package_confluence_pagination

Conversation

@P1llus

@P1llus P1llus commented Nov 6, 2023

Copy link
Copy Markdown
Member

Proposed commit message

Currently the pagination settings specifically for atlassian cloud do not have a failure condition on pagination, and therefore ends up paginating forever.

There is a few ways to resolve this, I think maybe the best approach would have been to simply utilize the "next" link that is included in each response, as the "next" value is missing once there is no more results. This is done for the on-prem version of confluence (and other atlassian products like jira).

However to keep the state working as it is, I have added the failure condition instead, which also works just fine.

There should be some investigation into making the pagination smarter on these niche scenarios.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@P1llus P1llus added Team:Security-External Integrations Integration:atlassian_confluence Atlassian Confluence bugfix Pull request that fixes a bug issue labels Nov 6, 2023
@P1llus
P1llus requested a review from a team as a code owner November 6, 2023 11:08
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Nov 6, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-06T15:12:56.663+0000

  • Duration: 25 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 6, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (24/24) 💚 24.242
Lines 98.795% (410/415) 👎 -1.205
Conditionals 100.0% (0/0) 💚
@P1llus

P1llus commented Nov 6, 2023

Copy link
Copy Markdown
Member Author

Resolving some issues with the params part of the new addition + adding more system tests so that it will finish instead of looping, as results are never 0.

@P1llus
P1llus merged commit c1b0699 into elastic:main Nov 6, 2023
@elasticmachine

Copy link
Copy Markdown

Package atlassian_confluence - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:atlassian_confluence Atlassian Confluence

3 participants