Skip to content

[Sophos] Fix parse of syslog priority from UTM events - #8437

Merged
chemamartinez merged 2 commits into
elastic:mainfrom
chemamartinez:fix-sophos-utm-priority
Nov 14, 2023
Merged

[Sophos] Fix parse of syslog priority from UTM events#8437
chemamartinez merged 2 commits into
elastic:mainfrom
chemamartinez:fix-sophos-utm-priority

Conversation

@chemamartinez

Copy link
Copy Markdown
Contributor

Proposed commit message

This PR fixes the processing of UTM events when they contain the syslog priority in the header.

In addition, from that priority, the following fields are mapped:

  • log.syslog.severity.code
  • log.syslog.severity.name
  • log.syslog.facility.code
  • log.syslog.facility.name

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Added syslog priority fields to several test cases in pipeline tests

Related issues

@chemamartinez chemamartinez self-assigned this Nov 8, 2023
@chemamartinez
chemamartinez marked this pull request as ready for review November 8, 2023 19:18
@chemamartinez
chemamartinez requested a review from a team as a code owner November 8, 2023 19:18
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Nov 8, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-14T17:21:28.313+0000

  • Duration: 18 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 8, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (17/17) 💚 3.823
Classes 100.0% (17/17) 💚 3.823
Methods 100.0% (125/125) 💚 7.744
Lines 91.053% (2534/2783) 👍 2.428
Conditionals 100.0% (0/0) 💚
@chemamartinez
chemamartinez force-pushed the fix-sophos-utm-priority branch from 9719e11 to c08436a Compare November 14, 2023 17:21
@chemamartinez
chemamartinez merged commit 0a91a0a into elastic:main Nov 14, 2023
@elasticmachine

Copy link
Copy Markdown

Package sophos - 3.6.1 containing this change is available at https://epr.elastic.co/search?package=sophos

@chemamartinez
chemamartinez deleted the fix-sophos-utm-priority branch February 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:sophos Sophos

3 participants