[GCP] [DNS logs] Don't parse rdata when it is empty - #8447
Merged
Conversation
zmoog
marked this pull request as ready for review
November 9, 2023 13:03
🌐 Coverage report
|
efd6
reviewed
Nov 13, 2023
zmoog
force-pushed
the
zmoog/fix-empty-rdata-in-gcp-dns-logs
branch
from
November 14, 2023 12:49
9bf8fea to
7a4be8e
Compare
Contributor
Author
|
Hey @efd6, do you think we should make other changes to this PR, or we're good? |
efd6
approved these changes
Nov 20, 2023
A user reported pipeline errors occurring when the `rdata` is set to an empty string. I am looking for the actual sample document from GCP, but in the meantime, I'm trying to reproduce the issue by modifying another test document.
…-rdata.log Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…ault.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
zmoog
force-pushed
the
zmoog/fix-empty-rdata-in-gcp-dns-logs
branch
from
November 21, 2023 04:56
7a4be8e to
09504e2
Compare
|
Package gcp - 2.31.2 containing this change is available at https://epr.elastic.co/search?package=gcp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Extends the pipeline
scriptprocessor check to processrdatafield only if it's not null and not an empty string.A user reported pipeline errors occurring when the
rdatais an empty string.Checklist
I have verified that all data streams collect metrics or logs.changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.How to test this PR locally
cd packages/gcp