Skip to content

Add 24h period configuration to all CSPM providers - #8516

Merged
romulets merged 2 commits into
elastic:mainfrom
romulets:main
Nov 15, 2023
Merged

Add 24h period configuration to all CSPM providers#8516
romulets merged 2 commits into
elastic:mainfrom
romulets:main

Conversation

@romulets

@romulets romulets commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Why

As mentioned on elastic/cloudbeat#1478 currently only CSPM AWS runs on a 24h cycle, GCP and Azure run on a 4h cycle (default value), while all CSPM should run on a 24h period.

What

Add 24h period configuration to all CSPMs. AWS already had, added to GCP and Azure.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • All CSPM have 24h period configured

Related issues
@romulets romulets added the bug Something isn't working, use only for issues label Nov 15, 2023
@romulets
romulets requested a review from jeniawhite November 15, 2023 11:58
@romulets romulets self-assigned this Nov 15, 2023
@romulets
romulets requested a review from a team as a code owner November 15, 2023 11:58
@romulets romulets changed the title Add 24h period configuration toall CSPM providers Nov 15, 2023
oren-zohar
oren-zohar suggested changes Nov 15, 2023
View reviewed changes

@oren-zohar oren-zohar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please verify these changes locally?
Comment thread packages/cloud_security_posture/changelog.yml Outdated
Comment thread packages/cloud_security_posture/manifest.yml Outdated
@elasticmachine

elasticmachine commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T13:30:10.819+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@romulets
romulets requested a review from oren-zohar November 15, 2023 12:14
@elasticmachine

elasticmachine commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@romulets
romulets force-pushed the main branch 2 times, most recently from 74a5cde to 28143ea Compare November 15, 2023 13:28
oren-zohar
oren-zohar approved these changes Nov 15, 2023
View reviewed changes

@oren-zohar oren-zohar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@romulets
romulets merged commit f1b08dd into elastic:main Nov 15, 2023
romulets added a commit that referenced this pull request Nov 15, 2023
@romulets
Revert "Add 24h period configuration to all CSPM providers (#8516)"
d3f9fec 
This reverts commit f1b08dd.
@elasticmachine

elasticmachine commented Nov 15, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview03 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Nov 21, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview04 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Nov 29, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Nov 30, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Dec 4, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Dec 5, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Dec 6, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0-preview09 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented Dec 6, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@romulets
Revert "Add 24h period configuration to all CSPM providers (#8516)"
03b6ffe 
This reverts commit eee96ef.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@romulets
Revert "Add 24h period configuration to all CSPM providers (#8516)"
89cdf0b 
This reverts commit 0351c96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management

5 participants

@romulets @elasticmachine @jeniawhite @oren-zohar @andrewkroh