Allow rerouting of Azure Metrics events to a different data stream - #8520
Merged
zmoog merged 2 commits intoNov 17, 2023
Conversation
🌐 Coverage report
|
tommyers-elastic
approved these changes
Nov 16, 2023
kaiyan-sheng
approved these changes
Nov 16, 2023
kaiyan-sheng
left a comment
There was a problem hiding this comment.
I need to do the same for aws 🙂
Contributor
Author
|
Thank you all for the reviews! ❤️ I also added the "How to test this PR locally" with tests using the pipeline simulator and actual documents to provide a reference mini-test suite for the next PRs. |
|
Package azure_metrics - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
Copilot AI
added a commit
that referenced
this pull request
Feb 8, 2026
…ynamic_namespace Remove dynamic_dataset and dynamic_namespace from all 8 azure_metrics data stream manifests. These settings were added for rerouting permissions (PR #8520) but are unnecessary since the ES reroute processor works at the Elasticsearch level. The settings caused Fleet to generate overly broad package-level templates (metrics-azure_metrics@template) that could conflict with templates from other packages like prometheus at the same priority (200). Reverts the previous prometheus changes - prometheus needs dynamic_dataset for its custom dataset name feature (data_stream.dataset variable). The azure_metrics datasets use azure.* prefix (e.g. azure.compute_vm) which differs from the package name (azure_metrics), causing the per-data-stream templates to overlap with the prometheus package-level template pattern (metrics-*.prometheus-*). Co-authored-by: wandergeek <597812+wandergeek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add permissions to reroute metrics events in all data streams in Azure Metrics.
The additional permissions will allow us to route metrics events to use the Azure resource type as dataset to partition metrics.
Rerouting can be set up by defining routing rules at the integration level or allowing users to add a reroute processor to the custom ingest pipeline.
Checklist
changelog.ymlfile.How to test this PR locally
_simulate
Here's a sample custom pipeline:
Note: don't forget to set
_indexto a valid value likemetrics-azure.monitor-default, or you'll get an error from the pipeline simulator.Test with a document that DOES NOT match the reroute condition:
Test with a document that DOES match the reroute condition:
Real documents
Here's test with an actual document.
Create a new document: