Skip to content

[Elasticsearch] Pipeline Convert Processor ignore_missing for elasticsearch.audit.user.run_as.name - #8522

Merged
smith merged 3 commits into
elastic:mainfrom
BenB196:elasticsearch-fix-pipeline
Nov 29, 2023
Merged

[Elasticsearch] Pipeline Convert Processor ignore_missing for elasticsearch.audit.user.run_as.name#8522
smith merged 3 commits into
elastic:mainfrom
BenB196:elasticsearch-fix-pipeline

Conversation

@BenB196

@BenB196 BenB196 commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Proposed commit message

Fixes an issue where elasticsearch.audit.user.run_as.name being missing would cause the processor to error (though ignored).

This is an issue because in high throughput clusters, these error numbers can skew failure ratios with other processors.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before Upgrade:

image

After Upgrade:

image

@BenB196
BenB196 requested a review from a team as a code owner November 16, 2023 00:14
@BenB196 BenB196 changed the title [Elasticsearch] Pipeline ignore_missing elasticsearch.audit.user.run_as.name Nov 16, 2023
@BenB196 BenB196 changed the title [Elasticsearch] Pipeline ignore_missing for elasticsearch.audit.user.run_as.name Nov 16, 2023
@elasticmachine

elasticmachine commented Nov 16, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T03:00:57.180+0000

  • Duration: 37 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@BenB196

BenB196 commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

@smith don't mean to bother, but I see you approved this PR, but it looks like someone needs to run the tests and then merge.

@smith

smith commented Nov 28, 2023

Copy link
Copy Markdown
Contributor

@elasticmachine test this please

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112)
Lines 91.993% (563/612)
Conditionals 100.0% (0/0) 💚
@smith
smith merged commit 440fd6b into elastic:main Nov 29, 2023
@elasticmachine

Copy link
Copy Markdown

Package elasticsearch - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

@BenB196
BenB196 deleted the elasticsearch-fix-pipeline branch November 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants