Skip to content

sophos: retain host name information in host.name as well as host.hostname - #8534

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:8528-sophos
Nov 21, 2023
Merged

sophos: retain host name information in host.name as well as host.hostname#8534
efd6 merged 1 commit into
elastic:mainfrom
efd6:8528-sophos

Conversation

@efd6

@efd6 efd6 commented Nov 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

The security app depends on the host.name field to be set in order for hosts to be visible. The utm datastream currently sets the host.hostname to the host name present in the syslog header. Copy that value across to host.name as lowercase to ensure that hosts are visible in the app.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • I'm not entirely convinced that this should be done; the ECS is weakly defined in this area.

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Nov 19, 2023
@efd6

efd6 commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

/test
@efd6
sophos: retain host name information in host.name as well as host.hos…
e280f40 
…tname

The security app depends on the host.name field to be set in order for
hosts to be visible. The utm datastream currently sets the host.hostname
to the host name present in the syslog header. Copy that value across to
host.name as lowercase to ensure that hosts are visible in the app.
@elasticmachine

elasticmachine commented Nov 20, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T01:15:29.053+0000

  • Duration: 18 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Nov 20, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (17/17) 💚
Classes 100.0% (17/17) 💚
Methods 100.0% (126/126) 💚 50.0
Lines 91.183% (2575/2824) 👎 -8.817
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review November 20, 2023 02:25
@efd6
efd6 requested a review from a team as a code owner November 20, 2023 02:25
@elasticmachine

elasticmachine commented Nov 20, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6
efd6 merged commit e9b0940 into elastic:main Nov 21, 2023
@elasticmachine

elasticmachine commented Nov 21, 2023

Copy link
Copy Markdown

Package sophos - 3.8.0 containing this change is available at https://epr.elastic.co/search?package=sophos
@efd6
efd6 deleted the 8528-sophos branch February 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sophos Sophos

3 participants

@efd6 @elasticmachine @bhapas