Skip to content

[integrations][Custom Azure Blob Storage] - Made integration GA, added new parameters & improved docs - #8577

Merged
ShourieG merged 6 commits into
elastic:mainfrom
ShourieG:abs/ga
Nov 28, 2023
Merged

[integrations][Custom Azure Blob Storage] - Made integration GA, added new parameters & improved docs#8577
ShourieG merged 6 commits into
elastic:mainfrom
ShourieG:abs/ga

Conversation

@ShourieG

@ShourieG ShourieG commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement
  • Documentation

Proposed commit message

  • Refactored the integration.
  • Added support for new Azure Blob Storage Input parameters according to 8.11 features.
  • Updated Kibana requirements to be 8.11 and above.
  • Updated System Test Config.
  • Improved the documentation to be GA ready.

Note

This integration was tested manually with a real ABS container on cloud with 100k+ logs. Screenshot of testing is attached below.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Add here screenshots presenting:

  • Test results of running Custom ABS integration with a real ABS container containing 100k+ logs
Screenshot 2023-11-27 at 12 25 55 PM Screenshot 2023-11-27 at 12 26 30 PM
@ShourieG
ShourieG requested a review from a team as a code owner November 27, 2023 07:06
@ShourieG ShourieG self-assigned this Nov 27, 2023
@ShourieG ShourieG added integration Label used for meta issues tracking each integration Team:Security-External Integrations labels Nov 27, 2023
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG added the enhancement New feature or request label Nov 27, 2023
@elasticmachine

elasticmachine commented Nov 27, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-28T10:58:53.427+0000

  • Duration: 16 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 27, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 100.0% (3/3) 💚 50.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@kgeller kgeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG
ShourieG merged commit 9ad8d5c into elastic:main Nov 28, 2023
@ShourieG
ShourieG deleted the abs/ga branch November 28, 2023 14:35
@elasticmachine

Copy link
Copy Markdown

Package azure_blob_storage - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=azure_blob_storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure_blob_storage Custom Azure Blob Storage Input integration Label used for meta issues tracking each integration

4 participants