Skip to content

[Security Solution] Update SentinelOne integration README with info. on configuring response actions - #8611

Merged
paul-tavares merged 13 commits into
elastic:mainfrom
paul-tavares:task/olm-7780-sentinelone-readme-update
Jan 19, 2024
Merged

[Security Solution] Update SentinelOne integration README with info. on configuring response actions#8611
paul-tavares merged 13 commits into
elastic:mainfrom
paul-tavares:task/olm-7780-sentinelone-readme-update

Conversation

@paul-tavares

@paul-tavares paul-tavares commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Adds information to the SentinelOne (S1) integration README file about the ability for sending Response Actions to S1 hosts
    • Changes goes along with Feature being implemented in Security Solution that supports sending isolate and release response actions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • none

How to test this PR locally

  • Start the stack using --version=8.12.0-SNAPSHOT:
elastic-package stack up -v -d --version=8.12.0-SNAPSHOT
  • Navigate to the SentinelOne integration page
    • Note that the version at the top is 1.20.0
    • Note the updated integration description that includes a link to Documentation
  • Click the documentation link
    • You will (until v8.12.0 is GA'd) received a 404 "Page not found". This is expected since v8.12 has not yet been released. The page is accessible however by changing the /current/ in the URL with /master/: image

Related issues

  • none

Screenshots

image
@paul-tavares paul-tavares added enhancement New feature or request v8.12.0 labels Nov 29, 2023
@paul-tavares paul-tavares self-assigned this Nov 29, 2023
Comment thread packages/sentinel_one/changelog.yml Outdated
@@ -1,5 +1,10 @@
# newer versions go on top
- version: "1.19.0"
- version: "1.20.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I doing this right? or should this be 1.20.0-next?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 1.20.0 only. the current change is correct.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're only updating docs, maybe we do a patch release for 1.19.1 instead of a new minor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷
hi @ebeahan - I'm not sure if that is the best way - this is the my first time making such changes. If you believe that is best I can change it. Please let me know

Comment thread packages/sentinel_one/manifest.yml Outdated
@elasticmachine

elasticmachine commented Nov 29, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T18:30:22.522+0000

  • Duration: 21 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@paul-tavares

Copy link
Copy Markdown
Contributor Author

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (71/71) 💚 75.0
Lines 96.387% (3175/3294) 👎 -3.613
Conditionals 100.0% (0/0) 💚
@paul-tavares
paul-tavares marked this pull request as ready for review November 29, 2023 20:33
@paul-tavares
paul-tavares requested a review from a team as a code owner November 29, 2023 20:33

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth waiting until 8.12 is released before this change is made.

@paul-tavares

Copy link
Copy Markdown
Contributor Author

Hi @efd6 - thanks for the quick feedback. I'll follow up with our team to see if that is ok. I'm thinking its fine given the nature of the change I'm introducing.

@paul-tavares
paul-tavares marked this pull request as draft December 5, 2023 13:57
@mrodm

mrodm commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

Hi @paul-tavares, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@elasticmachine

elasticmachine commented Jan 2, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@paul-tavares
paul-tavares requested review from joepeeples and removed request for kevinlog January 9, 2024 14:46
@paul-tavares
paul-tavares marked this pull request as ready for review January 10, 2024 19:28
@paul-tavares

Copy link
Copy Markdown
Contributor Author

Taking this out of draft as we are approaching the GA for v8.12.0.

@joepeeples joepeeples left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New content LGTM, and I added some extra edits in 74b731e which have already been incorporated. Thanks!

@paul-tavares
paul-tavares requested a review from efd6 January 17, 2024 21:14
@paul-tavares
paul-tavares requested a review from ebeahan January 19, 2024 00:22
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @paul-tavares

@paul-tavares
paul-tavares merged commit b4c2895 into elastic:main Jan 19, 2024
@paul-tavares
paul-tavares deleted the task/olm-7780-sentinelone-readme-update branch January 19, 2024 13:36
@elasticmachine

Copy link
Copy Markdown

Package sentinel_one - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=sentinel_one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sentinel_one SentinelOne v8.12.0

8 participants