You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adopt Secrets in Cloud Posture Management. A similar PR was created before, but reverted to not impact 8.12 release. This PR applies the changes to 1.8.0, therefore 8.13
This issue suggests potential secrets in cloud_secruity_posture. The following fields where labeled as secrets
cloudbeat/cis_eks
session_token
cloudbeat/cis_aws
secret_access_key
cloudbeat/cis_azure
azure.credentials.client_secret
azure.credentials.client_password
azure.credentials.client_certificate_password
Based on the criteria used of what potentially is a secret, more fields would have been classified as secret. Below you can find why they were not:
session_token: amazon doesn't consider it a secret, it's something temporary (@jeniawhite confirmed)
access_key_id: this always comes in pair with secret_access_key . I considered only the secret, a secret. The access key is plain text in AWS and in our integration page anyway. I believe only secret_access_key should be a secret.
Why
Adoption of secrets is a kibana wide effort to remove the possibility of secrets leaks in kibana (via system logs/audit or humans)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopt Secrets in Cloud Posture Management. A similar PR was created before, but reverted to not impact 8.12 release. This PR applies the changes to 1.8.0, therefore 8.13
This issue suggests potential secrets in cloud_secruity_posture. The following fields where labeled as secrets
cloudbeat/cis_ekssession_tokencloudbeat/cis_awssecret_access_keycloudbeat/cis_azureazure.credentials.client_secretazure.credentials.client_passwordazure.credentials.client_certificate_passwordBased on the criteria used of what potentially is a secret, more fields would have been classified as secret. Below you can find why they were not:
session_token: amazon doesn't consider it a secret, it's something temporary (@jeniawhite confirmed)access_key_id: this always comes in pair withsecret_access_key. I considered only the secret, a secret. The access key is plain text in AWS and in our integration page anyway. I believe onlysecret_access_keyshould be a secret.Why
Adoption of secrets is a kibana wide effort to remove the possibility of secrets leaks in kibana (via system logs/audit or humans)
Checklist
changelog.ymlfile.Author's Checklist
Related issues
Screenshots
Example of stored secret: