Skip to content

[Cloud Security] Remove disabled fields - #8679

Merged
kfirpeled merged 2 commits into
mainfrom
csp/drop-disabled-fields
Dec 11, 2023
Merged

[Cloud Security] Remove disabled fields#8679
kfirpeled merged 2 commits into
mainfrom
csp/drop-disabled-fields

Conversation

@opauloh

@opauloh opauloh commented Dec 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Remove fields that had enabled: false, to prevent mapping issues

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Follow the guide to test it locally.

Related issues

Screenshots
@opauloh opauloh changed the title Csp/drop disabled fields Dec 8, 2023
@elasticmachine

elasticmachine commented Dec 8, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-08T01:58:08.571+0000

  • Duration: 16 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Dec 8, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@opauloh opauloh added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Dec 9, 2023
@opauloh
opauloh marked this pull request as ready for review December 9, 2023 03:09
@opauloh
opauloh requested a review from a team as a code owner December 9, 2023 03:09
kfirpeled
kfirpeled approved these changes Dec 11, 2023
View reviewed changes

@kfirpeled kfirpeled left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kfirpeled
kfirpeled merged commit e86b8ee into main Dec 11, 2023
@kfirpeled
kfirpeled deleted the csp/drop-disabled-fields branch December 11, 2023 08:17
@elasticmachine

elasticmachine commented Dec 11, 2023

Copy link
Copy Markdown

Package cloud_security_posture - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@CohenIdo CohenIdo mentioned this pull request Jan 2, 2024
Merged
@maxcold maxcold mentioned this pull request Jan 2, 2024
Closed
4 tasks
@maxcold maxcold mentioned this pull request Jan 31, 2024
Closed
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

4 participants

@opauloh @elasticmachine @kfirpeled @andrewkroh