[Tenable IO] Add request tracing to vulnerability datastream and capture chain requests - #8831
Merged
Merged
Conversation
kcreddy
marked this pull request as ready for review
January 5, 2024 11:59
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset |
1326.26 | 855.43 | -470.83 (-35.5%) | 💔 |
To see the full report comment with /test benchmark fullreport
bhapas
approved these changes
Jan 5, 2024
bhapas
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Will you put up another PR after the beats issue is merged?
Contributor
Author
Yes, I will come up with a PR after. |
|
Package tenable_io - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io |
1 similar comment
|
Package tenable_io - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
vulnerabilitydatastream.NOTE: This PR hardcodes the tracer filenames instead of using the default filename
"../../logs/httpjson/http-request-trace-*.ndjson". This is because of the non-sanitisation of chain request tracer filenames explained in elastic/beats#37551Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package stack down && elastic-package build && elastic-package stack up --version=8.11.3 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test system --generate -v