Skip to content

[Keycloak] Make parsers configurable to support multiline logs - #8857

Merged
chemamartinez merged 6 commits into
elastic:mainfrom
chemamartinez:keycloak-add-parsers
Jan 23, 2024
Merged

[Keycloak] Make parsers configurable to support multiline logs#8857
chemamartinez merged 6 commits into
elastic:mainfrom
chemamartinez:keycloak-add-parsers

Conversation

@chemamartinez

@chemamartinez chemamartinez commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

In order to process multiline logs, this pull request makes the parsers configurable for the Keycloak integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Added multiline cases to pipeline tests

Screenshots

image
@chemamartinez chemamartinez self-assigned this Jan 11, 2024
@chemamartinez
chemamartinez marked this pull request as ready for review January 19, 2024 08:34
@chemamartinez
chemamartinez requested a review from a team as a code owner January 19, 2024 08:34
@elasticmachine

elasticmachine commented Jan 19, 2024

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 reviewed Jan 21, 2024
View reviewed changes
Comment thread packages/keycloak/data_stream/log/agent/stream/filestream.yml.hbs
@chemamartinez
chemamartinez requested a review from efd6 January 22, 2024 11:34
@elasticmachine

elasticmachine commented Jan 22, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
bhapas
bhapas reviewed Jan 22, 2024
View reviewed changes
Comment thread packages/keycloak/data_stream/log/_dev/test/pipeline/test-log.log Outdated
efd6
efd6 approved these changes Jan 22, 2024
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @bhapas suggestion applied.
@chemamartinez
chemamartinez requested a review from bhapas January 23, 2024 08:28
@elasticmachine

elasticmachine commented Jan 23, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @chemamartinez
@chemamartinez
chemamartinez merged commit 7f64623 into elastic:main Jan 23, 2024
@elasticmachine

elasticmachine commented Jan 23, 2024

Copy link
Copy Markdown

Package keycloak - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=keycloak
@narph narph added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jun 13, 2024
@elasticmachine

elasticmachine commented Jun 13, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@chemamartinez
chemamartinez deleted the keycloak-add-parsers branch February 6, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:keycloak Keycloak Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants

@chemamartinez @elasticmachine @efd6 @bhapas @narph