Skip to content

[TCP/UDP] Add missing ECS syslog mapping - #8870

Merged
chemamartinez merged 3 commits into
elastic:mainfrom
chemamartinez:tcp-udp-missing-syslog-mapping
Jan 12, 2024
Merged

[TCP/UDP] Add missing ECS syslog mapping#8870
chemamartinez merged 3 commits into
elastic:mainfrom
chemamartinez:tcp-udp-missing-syslog-mapping

Conversation

@chemamartinez

@chemamartinez chemamartinez commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

It has been reported an error in the Custom UDP integration. Since log.syslog.structured_data is not defined in the ECS template, each subfield in this object is mapped and indexed separately potentially leading to a mapping explosion.

This PR adds the missing log.syslog.* ECS mappings to the ECS template in UDP and TCP integrations, so the content of log.syslog.structured_data is mapped as a single field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/tcp && elastic-package test
cd packages/udp && elastic-package test
@chemamartinez chemamartinez added Team:Security-External Integrations bugfix Pull request that fixes a bug issue Integration:tcp Custom TCP Logs Integration:udp Custom UDP Logs labels Jan 12, 2024
@chemamartinez chemamartinez self-assigned this Jan 12, 2024
@chemamartinez
chemamartinez marked this pull request as ready for review January 12, 2024 10:24
@chemamartinez
chemamartinez requested a review from a team as a code owner January 12, 2024 10:24
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez
chemamartinez merged commit 69ceb82 into elastic:main Jan 12, 2024
@elasticmachine

Copy link
Copy Markdown

Package tcp - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=tcp

@elasticmachine

Copy link
Copy Markdown

Package udp - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=udp

@narph narph added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jun 13, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chemamartinez
chemamartinez deleted the tcp-udp-missing-syslog-mapping branch February 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:tcp Custom TCP Logs Integration:udp Custom UDP Logs Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants