Skip to content

[checkpoint] Improve authentication logs normalization - #8884

Merged
bhapas merged 2 commits into
elastic:mainfrom
bhapas:checkpoint_improve_8836
Jan 17, 2024
Merged

[checkpoint] Improve authentication logs normalization#8884
bhapas merged 2 commits into
elastic:mainfrom
bhapas:checkpoint_improve_8836

Conversation

@bhapas

@bhapas bhapas commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Problem described in #8836

Authentication events (logon, logoff) to be categorised as authentication events [ Instead of Network events ]
Sample Authentication events are added in the pipeline tests for the following scenarios

  • Login Success
  • Login Failed
  • Login Expert Shell
  • Logout

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack up -d -v && elastic-package test -v

Related issues

@bhapas bhapas self-assigned this Jan 15, 2024
@bhapas
bhapas requested a review from a team as a code owner January 15, 2024 10:50
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you flesh out the commit message, including noting the provenance of the test cases.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @bhapas

@bhapas
bhapas requested a review from efd6 January 16, 2024 14:12
@bhapas
bhapas merged commit b169c7c into elastic:main Jan 17, 2024
@elasticmachine

Copy link
Copy Markdown

Package checkpoint - 1.30.0 containing this change is available at https://epr.elastic.co/search?package=checkpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point

3 participants