Skip to content

m365_defender: add geoip processing to {source,destination}.ip - #8899

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:8891-m365_defender
Jan 17, 2024
Merged

m365_defender: add geoip processing to {source,destination}.ip#8899
efd6 merged 1 commit into
elastic:mainfrom
efd6:8891-m365_defender

Conversation

@efd6

@efd6 efd6 commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jan 17, 2024
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
efd6 force-pushed the 8891-m365_defender branch 2 times, most recently from f8b8e7f to cb0417e Compare January 17, 2024 03:55
@efd6
efd6 marked this pull request as ready for review January 17, 2024 03:57
@efd6
efd6 requested a review from a team as a code owner January 17, 2024 03:57
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment thread packages/m365_defender/changelog.yml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr number

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge once the PR number in changelog is fixed.

@efd6
efd6 force-pushed the 8891-m365_defender branch from cb0417e to 667443c Compare January 17, 2024 10:32

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #8131 succeeded cb0417e40884fc669c82f3f314bef0ae973c3970
  • 💚 Build #8129 succeeded 02c6c44678c75c2d5b168a9c5b983d452aa82f6b

cc @efd6

@efd6
efd6 merged commit 51b18d4 into elastic:main Jan 17, 2024
@elasticmachine

Copy link
Copy Markdown

Package m365_defender - 2.6.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@narph narph added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jun 13, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
efd6 deleted the 8891-m365_defender branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants