ZeroNetworks V2.0.0 - #8934
Conversation
|
Is there an issue for this? |
|
@efd6 no. Just an enhancement. |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
Can you provide a link in the PR description that we can use in the commit message detailing the source of information justifying the change.
|
/test |
You can resolve this by adding the diff --git a/packages/zeronetworks/validation.yml b/packages/zeronetworks/validation.yml
index a96151416..c8f642bce 100644
--- a/packages/zeronetworks/validation.yml
+++ b/packages/zeronetworks/validation.yml
@@ -1,3 +1,4 @@
errors:
exclude_checks:
+ - SVR00002
- SVR00005 # Kibana version for saved tags. |
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Done |
No sir. We don't have public docs as a startup. I am confused a bit too. I assume you are referring to the changes in audit types? not the dashboard add. For dashboard we just want to make the integration better for our customers. for auditypes, we are growing company adding features based on customer feedback. This will continue to evolve over time. |
This is the relevant answer. Thanks. I did not know that you were associated with ZeroNetworks. When documentation is available, it would be good to link. Making docs a priority is beneficial. |
|
/test |
|
Thanks for continuing to enhance the integration @dicolanl. Do you mind if we adjust the |
|
@jamiehynds sure. Tell me what you like to put. When I built it. I couldn't find any samples with external companies listed. |
|
@jamiehynds updated owner. |
|
/test |
|
/test |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
|
/test |
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
The version in the manifest will need to be updated to match the changelog.
Error: checking package failed: linting package failed: found 1 validation error:
1. current manifest version doesn't have changelog entry
|
fixed maifest |
|
/test |
|
@efd6 updated last week. |
|
/test |
|
The system tests are not getting any events. |
|
Why would it not work in the cloud? I ran system test on my laptop was fine. Nothing changed since I shared that output with events. |
|
I will try to take a look later in the week. |
|
It looks like maybe pagination is not working correctly. When I run this locally, I only get 5 events coming through in the system tests. This count corresponds with the number of events in each of the rules you have defined in the system test deployment configs. |
|
@efd6 I noticed that the second call is changing the "from" param to 1.7...... why is not sending epochms like the first call??? So I created new elastic stack in docker, went to the web and connected the integration to the real api. now it seems, which i didnt change anything in the httpjson.yml.hbs file that its setting cursor incorrrectly, so maybe something in the agent changed and im handling cursor wrong? |
|
The agent won't have changed. I can take a look again next week. |
|
I think I found the problem. I'll update soon. It was saving the next cursor as a string. Not int. |
System test works now --- Test results for package: zeronetworks - START --- ╭──────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├──────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤ │ zeronetworks │ audit │ system │ default │ PASS │ 34.809901167s │ ╰──────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯ --- Test results for package: zeronetworks - END ---
|
@efd6 found a bug with paging. once I fixed that found some other issues with fields missing. so fixed everything. |
|
/test |
💚 Build Succeeded
History
|
|
|
Package zeronetworks - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=zeronetworks |
6 participants
-Added a dashboard
-Updated AuditTypes
Checklist
changelog.ymlfile.