Skip to content

[imperva_cloud_waf] Initial release of the imperva cloud waf - #8999

Merged
efd6 merged 4 commits into
elastic:mainfrom
janvi-elastic:package_imperva_cloud_waf
Jan 31, 2024
Merged

[imperva_cloud_waf] Initial release of the imperva cloud waf#8999
efd6 merged 4 commits into
elastic:mainfrom
janvi-elastic:package_imperva_cloud_waf

Conversation

@janvi-elastic

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Generated the skeleton of the Imperva Cloud WAF integration package.
  • Added data stream.
  • Added data collection logic for event data stream.
  • Added the ingest pipeline for event data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added dashboards and visualizations.
  • Added test for pipeline for event data stream.
  • Added system test cases for event data stream.

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target is documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to: ^8.10.1

New Package

  • Screenshot of the "Add Integration" page on Fleet added

Dashboards changes

  • Dashboards exists
  • Screenshots added or updated
  • Datastream filters added to visualizations

Log dataset changes

  • Pipeline tests exist (if applicable)
  • Generated output for at least 1 log file exists
  • Sample event (sample_event.json) exists

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/imperva_cloud_waf directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Automated Test

--- Test results for package: imperva_cloud_waf - START ---
╭───────────────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE           │ DATA STREAM │ TEST TYPE │ TEST NAME                                                                  │ RESULT │ TIME ELAPSED │
├───────────────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ imperva_cloud_waf │             │ asset     │ dashboard imperva_cloud_waf-6fbc3530-9a84-11ee-b689-05e9d8af2773 is loaded │ PASS   │      7.023µs │
│ imperva_cloud_waf │             │ asset     │ search imperva_cloud_waf-4c603c80-9a84-11ee-b689-05e9d8af2773 is loaded    │ PASS   │       2.23µs │
│ imperva_cloud_waf │             │ asset     │ search imperva_cloud_waf-c10e98f0-9cbf-11ee-b689-05e9d8af2773 is loaded    │ PASS   │      2.183µs │
│ imperva_cloud_waf │ event       │ asset     │ index_template logs-imperva_cloud_waf.event is loaded                      │ PASS   │      2.291µs │
│ imperva_cloud_waf │ event       │ asset     │ ingest_pipeline logs-imperva_cloud_waf.event-0.1.0 is loaded               │ PASS   │      2.569µs │
╰───────────────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: imperva_cloud_waf - END   ---
Done
--- Test results for package: imperva_cloud_waf - START ---
╭───────────────────┬─────────────┬───────────┬─────────────────┬────────┬──────────────╮
│ PACKAGE           │ DATA STREAM │ TEST TYPE │ TEST NAME       │ RESULT │ TIME ELAPSED │
├───────────────────┼─────────────┼───────────┼─────────────────┼────────┼──────────────┤
│ imperva_cloud_waf │ event       │ pipeline  │ test-event.json │ PASS   │  39.824252ms │
╰───────────────────┴─────────────┴───────────┴─────────────────┴────────┴──────────────╯
--- Test results for package: imperva_cloud_waf - END   ---
Done

--- Test results for package: imperva_cloud_waf - START ---
╭───────────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE           │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├───────────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ imperva_cloud_waf │ event       │ static    │ Verify sample_event.json │ PASS   │ 244.679318ms │
╰───────────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: imperva_cloud_waf - END   ---
Done

--- Test results for package: imperva_cloud_waf - START ---
╭───────────────────┬─────────────┬───────────┬───────────┬────────┬─────────────────╮
│ PACKAGE           │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │    TIME ELAPSED │
├───────────────────┼─────────────┼───────────┼───────────┼────────┼─────────────────┤
│ imperva_cloud_waf │ event       │ system    │ default   │ PASS   │ 2m38.376375576s │
╰───────────────────┴─────────────┴───────────┴───────────┴────────┴─────────────────╯
--- Test results for package: imperva_cloud_waf - END   ---
Done

Screenshot

image
image

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jamiehynds
jamiehynds requested a review from a team January 30, 2024 10:03
@jamiehynds jamiehynds added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] New Integration Issue or pull request for creating a new integration package. labels Jan 30, 2024
Comment thread packages/imperva_cloud_waf/data_stream/event/agent/stream/cel.yml.hbs Outdated
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@efd6
efd6 merged commit e08298c into elastic:main Jan 31, 2024
@elasticmachine

Copy link
Copy Markdown

Package imperva_cloud_waf - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=imperva_cloud_waf

@andrewkroh andrewkroh added the Integration:imperva_cloud_waf Imperva Cloud WAF label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:imperva_cloud_waf Imperva Cloud WAF New Integration Issue or pull request for creating a new integration package. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants