Skip to content

[akamai] add api emulator for realistic testing - #9042

Merged
andrewkroh merged 2 commits into
elastic:mainfrom
andrewkroh:akamai/feature/emulator-test
Feb 8, 2024
Merged

[akamai] add api emulator for realistic testing#9042
andrewkroh merged 2 commits into
elastic:mainfrom
andrewkroh:akamai/feature/emulator-test

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

This simulates the Akamai SIEM API. It provides realistic validation of request signatures. It emulates the time and offset based queries by simulating a world in which a new event happens every 5 minutes. The offset cursor is simply the unix time in sec of the last returned event.

This is a reproducer for the issues described in #9038. Those issues only occur when the tests in this changeset run on Elastic Agent < 8.11.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@elasticmachine

elasticmachine commented Feb 2, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@andrewkroh
akamai - add api emulator for realistic testing
e4cd2c1 
This simulates the Akamai SIEM API. It provides realistic validation of
request signatures. It emulates the time and offset based queries by
simulating a world in which a new event happens every 5 minutes. The
offset cursor is simply the unix time in sec of the last returned event.

This is a reproducer for the issues described in #9038. Those issues
only occur on Elastic Agent < 8.11.0.
@andrewkroh
bump stack version
94dd9e8
@elastic-sonarqube

elastic-sonarqube Bot commented Feb 2, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Feb 2, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #8585 succeeded 52b5fae14350d450a55ecee2b2cdfa2f8e4cfa4b
  • 💔 Build #8579 failed 6342440fe9dc9761036b20616a4aada7413f578d
@andrewkroh
andrewkroh marked this pull request as ready for review February 2, 2024 15:44
@andrewkroh
andrewkroh requested a review from a team as a code owner February 2, 2024 15:44
efd6
efd6 approved these changes Feb 2, 2024
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could have the emulator code in this repo and have it reviewed as well (I looked at it and it seems fine).
@andrewkroh

andrewkroh commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

It would be nice if we could have the emulator code in this repo and have it reviewed as well (I looked at it and it seems fine).

This was something I was debating with myself. I was thinking that perhaps it should be in some external elastic repo where we have CI and linting running specifically for Go code plus using our normal code review process.
@andrewkroh
andrewkroh merged commit c048a13 into elastic:main Feb 8, 2024
@andrewkroh andrewkroh mentioned this pull request Feb 8, 2024
Closed
@elasticmachine

elasticmachine commented Feb 8, 2024

Copy link
Copy Markdown

Package akamai - 2.22.0 containing this change is available at https://epr.elastic.co/search?package=akamai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:akamai Akamai

3 participants

@andrewkroh @elasticmachine @efd6