Add cluster config for kind create cluster command - #908
Merged
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
Pinging @elastic/integrations (Team:Integrations) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mtojek
reviewed
Apr 15, 2021
| kubectl version --client | ||
| ''') } | ||
| sh(label: "Create kind cluster", script: 'kind create cluster') | ||
| sh(label: "Create kind cluster", script: 'kind create cluster --config - $PWD/../../testing/environments/kubernetes/kind-config.yaml') |
Contributor
There was a problem hiding this comment.
Wow, I totally forgot about that directory. Actually I should remove it totally...
As this is a config file, maybe we could keep just at the root as this one: https://github.com/elastic/integrations/blob/master/config.yml
WDYT?
Member
Author
There was a problem hiding this comment.
ah ok! I can move it there!
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mtojek
approved these changes
Apr 15, 2021
mtojek
left a comment
mtojek
left a comment
Contributor
There was a problem hiding this comment.
If the CI is happy, please consider this PR as approved :)
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
kind_cluster_config
branch
from
April 15, 2021 10:00
5307d96 to
3612109
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
kind_cluster_config
branch
from
April 15, 2021 10:03
3612109 to
fb6fc9a
Compare
jsoriano
reviewed
Apr 15, 2021
| kubectl version --client | ||
| ''') } | ||
| sh(label: "Create kind cluster", script: 'kind create cluster') | ||
| sh(label: "Create kind cluster", script: 'kind create cluster --config ../../kind-config.yaml') |
Contributor
There was a problem hiding this comment.
If this config is in the root of the project, try with BASE_DIR
Suggested change
| sh(label: "Create kind cluster", script: 'kind create cluster --config ../../kind-config.yaml') | |
| sh(label: "Create kind cluster", script: 'kind create cluster --config ${BASE_DIR}/kind-config.yaml') |
Member
Author
There was a problem hiding this comment.
it seems to pass with ../../kind-config.yaml 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes how we start kind cluster for k8s tests so as to be able to expose kube-proxy's metrics.
Related to #886, elastic/elastic-package#322, https://github.com/elastic/elastic-package/tree/master/internal/install