Skip to content

[tenable_sc] Clean up null handling - #9152

Merged
chrisberkhout merged 3 commits into
elastic:mainfrom
chrisberkhout:tenable_sc-null-handling
Feb 19, 2024
Merged

[tenable_sc] Clean up null handling#9152
chrisberkhout merged 3 commits into
elastic:mainfrom
chrisberkhout:tenable_sc-null-handling

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

[tenable_sc] Clean up null handling (#)

- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@chrisberkhout chrisberkhout added Integration:tenable_sc Tenable Security Center Team:Service-Integrations Label for the Observability Service Integrations team bugfix Pull request that fixes a bug issue labels Feb 14, 2024
@chrisberkhout chrisberkhout self-assigned this Feb 14, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner February 14, 2024 16:30
@chrisberkhout chrisberkhout mentioned this pull request Feb 14, 2024
Open
39 tasks
@elasticmachine

elasticmachine commented Feb 14, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
efd6
efd6 reviewed Feb 14, 2024
View reviewed changes
Comment thread packages/tenable_sc/data_stream/vulnerability/elasticsearch/ingest_pipeline/default.yml Outdated
@elasticmachine

elasticmachine commented Feb 15, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @chrisberkhout
@elastic-sonarqube

elastic-sonarqube Bot commented Feb 15, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
57.1% 57.1% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@chrisberkhout
chrisberkhout merged commit 083a3bc into elastic:main Feb 19, 2024
@chrisberkhout
chrisberkhout deleted the tenable_sc-null-handling branch February 19, 2024 11:08
@elasticmachine

elasticmachine commented Feb 19, 2024

Copy link
Copy Markdown

Package tenable_sc - 1.20.2 containing this change is available at https://epr.elastic.co/search?package=tenable_sc
gizas pushed a commit that referenced this pull request Mar 13, 2024
@chrisberkhout @gizas
[tenable_sc] Clean up null handling (#9152)
a10934d 
- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@chrisberkhout @gizas
[tenable_sc] Clean up null handling (#9152)
97e0e3a 
- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@chrisberkhout @gizas
[tenable_sc] Clean up null handling (#9152)
d5086c5 
- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:tenable_sc Tenable Security Center Team:Service-Integrations Label for the Observability Service Integrations team

3 participants

@chrisberkhout @elasticmachine @efd6