Skip to content

[imperva_cloud_waf] Added Visualizations and updated Dashboard - #9210

Merged
kcreddy merged 3 commits into
elastic:mainfrom
janvi-elastic:package_imperva_cloud_waf-0.2.0
Feb 22, 2024
Merged

[imperva_cloud_waf] Added Visualizations and updated Dashboard#9210
kcreddy merged 3 commits into
elastic:mainfrom
janvi-elastic:package_imperva_cloud_waf-0.2.0

Conversation

@janvi-elastic

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Added Attack Map, Events Over Time, Unique IP and Unique domain metrics visualizations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/imperva_cloud_waf directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

imperva-cwaf-dashboard

@janvi-elastic
janvi-elastic requested a review from a team as a code owner February 21, 2024 11:23
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy added enhancement New feature or request Integration:imperva_cloud_waf Imperva Cloud WAF labels Feb 21, 2024

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.11 introduces a new panel Links which helps in creating easier links between dashboards and external links. If there is no requirement to stay at 8.10.1, we should increase kibana.version: ^8.12.0 and also update/remove the markdown in favour of new Links panel.

Here is the PR which has the recording of this feature: elastic/kibana#166896

Comment on lines +99 to +102
{{#if processors}}
processors:
{{processors}}
{{/if}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already processors: key above this. Test by adding a custom processor for any syntax/indentation issue.

Suggested change
{{#if processors}}
processors:
{{processors}}
{{/if}}
{{#if processors}}
{{processors}}
{{/if}}
Comment on lines +100 to +103
{{#if processors}}
processors:
{{processors}}
{{/if}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kcreddy
kcreddy merged commit d987147 into elastic:main Feb 22, 2024
@elasticmachine

Copy link
Copy Markdown

Package imperva_cloud_waf - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=imperva_cloud_waf

gizas pushed a commit that referenced this pull request Mar 13, 2024
* Added Attack Map, Events Over Time, Unique IP and domain visualizations.
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
* Added Attack Map, Events Over Time, Unique IP and domain visualizations.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* Added Attack Map, Events Over Time, Unique IP and domain visualizations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:imperva_cloud_waf Imperva Cloud WAF

3 participants