Skip to content

Set sensitive values as secret in services integrations - #9238

Merged
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:enhance/secrets-extras
Mar 4, 2024
Merged

Set sensitive values as secret in services integrations#9238
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:enhance/secrets-extras

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Set sensitive values in several services integrations as secret
  • Marked non-sensitive values as not a secret
  • Upgraded pkg-spec to 3.0.3 where possible, gaining secrets validation from 3.0.2

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#7388
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:crowdstrike CrowdStrike Integration:forcepoint_web Forcepoint Web Security (Community supported) Integration:eset_protect ESET PROTECT Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:ti_eclecticiq EclecticIQ (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF Integration:ti_threatconnect ThreatConnect labels Feb 23, 2024
@taylor-swanson taylor-swanson self-assigned this Feb 23, 2024
@elasticmachine

elasticmachine commented Feb 23, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

Package eset_protect 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
detection 1776.2 1132.5 -643.7 (-36.24%) 💔

Package imperva_cloud_waf 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 1564.95 1106.19 -458.76 (-29.31%) 💔

Package ti_crowdstrike 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
intel 1876.17 1404.49 -471.68 (-25.14%) 💔
ioc 4132.23 2762.43 -1369.8 (-33.15%) 💔

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Feb 23, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Feb 23, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @taylor-swanson
@taylor-swanson
taylor-swanson marked this pull request as ready for review February 23, 2024 20:22
@taylor-swanson
taylor-swanson requested a review from a team as a code owner February 23, 2024 20:22
@elasticmachine

elasticmachine commented Feb 23, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
ShourieG
ShourieG approved these changes Mar 4, 2024
View reviewed changes

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@taylor-swanson
taylor-swanson merged commit dcb25f9 into elastic:main Mar 4, 2024
@taylor-swanson
taylor-swanson deleted the enhance/secrets-extras branch March 4, 2024 14:07
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package crowdstrike - 1.32.0 containing this change is available at https://epr.elastic.co/search?package=crowdstrike
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package eset_protect - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=eset_protect
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package forcepoint_web - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=forcepoint_web
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package imperva_cloud_waf - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=imperva_cloud_waf
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package ti_crowdstrike - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=ti_crowdstrike
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package ti_eclecticiq - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=ti_eclecticiq
@elasticmachine

elasticmachine commented Mar 4, 2024

Copy link
Copy Markdown

Package ti_threatconnect - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=ti_threatconnect
gizas pushed a commit that referenced this pull request Mar 13, 2024
@taylor-swanson @gizas
Set sensitive values as secret in services integrations (#9238)
50830c7 
- Set sensitive values in several services integrations as secret
- Marked non-sensitive values as not a secret
- Upgraded pkg-spec to 3.0.3 where possible, gaining secrets validation from 3.0.2
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@taylor-swanson @gizas
Set sensitive values as secret in services integrations (#9238)
3e7865b 
- Set sensitive values in several services integrations as secret
- Marked non-sensitive values as not a secret
- Upgraded pkg-spec to 3.0.3 where possible, gaining secrets validation from 3.0.2
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@taylor-swanson @gizas
Set sensitive values as secret in services integrations (#9238)
99478be 
- Set sensitive values in several services integrations as secret
- Marked non-sensitive values as not a secret
- Upgraded pkg-spec to 3.0.3 where possible, gaining secrets validation from 3.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:crowdstrike CrowdStrike Integration:eset_protect ESET PROTECT Integration:forcepoint_web Forcepoint Web Security (Community supported) Integration:imperva_cloud_waf Imperva Cloud WAF Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:ti_eclecticiq EclecticIQ (Partner supported) Integration:ti_threatconnect ThreatConnect Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@taylor-swanson @elasticmachine @ShourieG