Skip to content

Add custom processors and tags to gcp storage integration - #9252

Merged
ishleenk17 merged 7 commits into
elastic:mainfrom
juorain:storage
Mar 28, 2024
Merged

Add custom processors and tags to gcp storage integration#9252
ishleenk17 merged 7 commits into
elastic:mainfrom
juorain:storage

Conversation

@juorain

@juorain juorain commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Add custom processors and tags to gcp storage integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@cla-checker-service

cla-checker-service Bot commented Feb 28, 2024

Copy link
Copy Markdown

💚 CLA has been signed

Comment thread packages/gcp/changelog.yml Outdated
@juorain
juorain marked this pull request as ready for review February 28, 2024 10:22
@juorain
juorain requested review from a team as code owners February 28, 2024 10:22

@francescayeye francescayeye left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please. see my comment

Comment thread packages/gcp/data_stream/storage/manifest.yml
@Lucas-Feat

Copy link
Copy Markdown
Contributor

Hi,
Can we know why this PR is on hold ?

Thkx

Comment thread packages/gcp/data_stream/storage/manifest.yml Outdated
@ishleenk17

Copy link
Copy Markdown
Member

Hi, Can we know why this PR is on hold ?

Thkx

There should not be any holdup. ITs a pretty straightforward one. Left few comments.

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Comment thread packages/gcp/changelog.yml Outdated
Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Comment thread packages/gcp/data_stream/storage/manifest.yml
@ishleenk17

Copy link
Copy Markdown
Member

Let the CI pass, then we are GTG.

@ishleenk17

Copy link
Copy Markdown
Member

/test

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17

Copy link
Copy Markdown
Member

@elastic/security-service-integrations : Could you please review as well.

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/gcp/data_stream/storage/agent/stream/stream.yml.hbs Outdated
Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
@ishleenk17

Copy link
Copy Markdown
Member

/test

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ishleenk17

Copy link
Copy Markdown
Member

@elastic/obs-ds-hosted-services : Could you please review as well

@ishleenk17
ishleenk17 merged commit 9d41732 into elastic:main Mar 28, 2024
@elasticmachine

Copy link
Copy Markdown

Package gcp - 2.33.2 containing this change is available at https://epr.elastic.co/search?package=gcp

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform

9 participants