Skip to content

microsoft_defender_endpoint: fix handling of empty array fields - #9338

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:9320-microsoft_defender_endpoint
Mar 13, 2024
Merged

microsoft_defender_endpoint: fix handling of empty array fields#9338
efd6 merged 1 commit into
elastic:mainfrom
efd6:9320-microsoft_defender_endpoint

Conversation

@efd6

@efd6 efd6 commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

When the evidence field in the input is a zero length array some processors fail due to direct access of subfields. It appears that sometimes this field is sent as an array rather than an object when empty, rather than as a null. So remove all empty arrays and objects at the beginning of the pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Mar 12, 2024
@efd6 efd6 self-assigned this Mar 12, 2024
@efd6
efd6 force-pushed the 9320-microsoft_defender_endpoint branch from 4a2e904 to ab343bd Compare March 12, 2024 05:49
When the evidence field in the input is a zero length array some
processors fail due to direct access of subfields. It appears that
sometimes this field is sent as an array rather than an object when
empty, rather than as a null. So remove all empty arrays and objects at
the beginning of the pipeline.
@efd6
efd6 force-pushed the 9320-microsoft_defender_endpoint branch from ab343bd to 1d05cf5 Compare March 12, 2024 05:53
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6
efd6 marked this pull request as ready for review March 12, 2024 06:52
@efd6
efd6 requested a review from a team as a code owner March 12, 2024 06:52
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6
efd6 merged commit 269e7d3 into elastic:main Mar 13, 2024
@elasticmachine

Copy link
Copy Markdown

Package microsoft_defender_endpoint - 2.24.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

gizas pushed a commit that referenced this pull request Mar 13, 2024
When the evidence field in the input is a zero length array some
processors fail due to direct access of subfields. It appears that
sometimes this field is sent as an array rather than an object when
empty, rather than as a null. So remove all empty arrays and objects at
the beginning of the pipeline.
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
When the evidence field in the input is a zero length array some
processors fail due to direct access of subfields. It appears that
sometimes this field is sent as an array rather than an object when
empty, rather than as a null. So remove all empty arrays and objects at
the beginning of the pipeline.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
When the evidence field in the input is a zero length array some
processors fail due to direct access of subfields. It appears that
sometimes this field is sent as an array rather than an object when
empty, rather than as a null. So remove all empty arrays and objects at
the beginning of the pipeline.
@efd6
efd6 deleted the 9320-microsoft_defender_endpoint branch February 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants