Skip to content

[kubernetes] Migrate to format_version v3 - #9356

Merged
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:kubernetes-package-spec-v3
Mar 13, 2024
Merged

[kubernetes] Migrate to format_version v3#9356
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:kubernetes-package-spec-v3

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

  • WHAT: Migrate to format_version v3 and address corresponding errors:
Error: building package failed: invalid content found in built zip package: found 6 validation errors:
   1. file "/Users/tetianakravchenko/go/src/github.com/elastic/integrations/build/packages/kubernetes-1.58.0.zip/data_stream/apiserver/fields/fields.yml" is invalid: field 0.fields.20.fields.3: object_type is required
   2. file "/Users/tetianakravchenko/go/src/github.com/elastic/integrations/build/packages/kubernetes-1.58.0.zip/data_stream/container_logs/manifest.yml" is invalid: field (root): Additional property elasticsearch.dynamic_dataset is not allowed
   3. file "/Users/tetianakravchenko/go/src/github.com/elastic/integrations/build/packages/kubernetes-1.58.0.zip/data_stream/container_logs/manifest.yml" is invalid: field (root): Additional property elasticsearch.dynamic_namespace is not allowed
   4. file "/Users/tetianakravchenko/go/src/github.com/elastic/integrations/build/packages/kubernetes-1.58.0.zip/manifest.yml" is invalid: field owner: type is required
   5. file "/Users/tetianakravchenko/go/src/github.com/elastic/integrations/build/packages/kubernetes-1.58.0.zip/manifest.yml" is invalid: field conditions: Additional property kibana.version is not allowed
   6. references found in dashboard kibana/dashboard/kubernetes-f4dc26db-1b53-4ea2-a78b-1bfab8ea267c.json: kubernetes-ee55101a-9f62-44da-b64c-ffa1eb5abad8 (search) (SVR00004)

Note: visualization migration was done using this tool - https://github.com/elastic/visualizations_integrations_tools/blob/master/inline.js

  • WHY: use the latest format_version

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Kibana dashboards were migrated using:

KIBANA="https://elastic:changeme@localhost:5601" node inline.js <path>/github.com/elastic/integrations/packages/kubernetes/kibana

Checked dashboard:

  • working after the package upgrade
  • working when installed latest version

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

description: Request duration, number of operations
- name: duration.us.bucket.*
type: object
object_type: long

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbondyra mbondyra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙆🏼‍♀️

@tetianakravchenko
tetianakravchenko merged commit 0461976 into elastic:main Mar 13, 2024
@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.58.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.59.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants