[O11y][Redis Enterprise] Fix intervals in the visualizations of Overview dashboard by harnish-crest-data · Pull Request #9464 · elastic/integrations

harnish-crest-data · 2024-03-28T06:34:07Z

Proposed commit message

Fix intervals in the visualizations of Overview dashboard.
As per discussion with @tommyers-elastic, we need a little more thought to improve this dashboard more than just changing the agg types.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Related issues

Closes [Redis Enterprise] Fix dashboard visualizations #8603

Screenshots

Before

After

…Overview dashboard

niraj-elastic

LGTM!

agithomas · 2024-04-02T13:32:37Z

                                                    "isBucketed": false,
                                                    "label": "Total requests (ops/sec)",
-                                                    "operationType": "average",
+                                                    "operationType": "last_value",


Here in the label it says - Total Requests (ops/sec).

If it is a rate such as ops/sec, using average may not be entirely wrong. If it is a counter, showing last value or rate of change of the value will be appropriate.

So, what does the field description of redisenterprise.node.total_req.value: * say in the official documentation? I can't find it in the fields.yml.

Here is the official document. I agree to your point that If it is a rate such as ops/sec, using average may not be entirely wrong. Let me revert it for the visualizations that showing rate such as ops/sec or bytes/sec. Thanks!

agithomas · 2024-04-03T19:47:57Z

                                                    "isBucketed": false,
                                                    "label": "System CPU time",
-                                                    "operationType": "average",
+                                                    "operationType": "last_value",


If this is a gauge type, average makes more sense than last value.

agithomas · 2024-04-03T19:48:19Z

                                                    "dataType": "number",
+                                                    "filter": {
+                                                        "language": "kuery",
+                                                        "query": "redisenterprise.node.cpu_user.value: *"


If this is a gauge type, average makes more sense than last value.

agithomas · 2024-04-03T19:52:04Z

                                                    "isBucketed": false,
                                                    "label": "Connections",
-                                                    "operationType": "average",
+                                                    "operationType": "last_value",


Is this a counter or gauge? If counter, last_value make sense. Else gauge.

The change from avg -> last value is significant as part of this viz change. Can you create a table having information of

name of field, gauge or counter , recommended operationType value.

It will be easy to review and recommend.

harnish-crest-data · 2024-04-05T05:52:57Z

@agithomas If any field used in the visualization is of format redisenterprise.node.*.value then it's a gauge field as per the metric_type. Else if it is like redisenterprise.proxy.*.counter then it is counter. IMO fields like redisenterprise.node.cpu_system.value, redisenterprise.node.cpu_user.value, redisenterprise.node.conns.value are showing values which are related to % cores utilization, CPU time and Number of clients connected to endpoints on node which makes sense to give priority of the last value being fetched.

agithomas · 2024-04-20T04:13:19Z

@harnish-elastic ,If i have to choose an aggregation other than average, it will be as follows.

Visualization Name	Field Used	Aggregation Used (Before)	Recommended (if not average)
System CPU time	redisenterprise.node.cpu_system.value	Average	Average
Free ephemeral disk space	redisenterprise.node.ephemeral_storage_free.value	Average	Last Value
User CPU time	redisenterprise.node.cpu_user.value	Average	Average
Total client connections	redisenterprise.node.conns.value	Average	Max
Node free memory	redisenterprise.node.free_memory.value	Average	Min
Rate of incoming/outgoing network traffic	redisenterprise.node.egress_bytes.value, redisenterprise.node.ingress_bytes.value	Average	Max

If I have to think of a mistake, it will be only redisenterprise.node.ephemeral_storage_free.value, where last_value() is the correct one, provided the metric is a counter.

@tommyers-elastic , can you please validate this please?

agithomas · 2024-04-20T04:19:56Z

If you choose to use an aggregation function other than Avg() on any metrics other than redisenterprise.node.ephemeral_storage_free.value, please validate the viz title. It may also need a change to reflect what the viz is trying to convey to the user.

agithomas · 2024-05-01T20:35:17Z

 # newer versions go on top
+- version: "0.10.0"
+  changes:
+    - description: Fix aggregations, intervals and fields used in the visualizations of Overview dashboard.


I suppose this description is not relevant anymore. Please correct.

Also, please update the PR description / title

Updated, thanks!

agithomas · 2024-05-02T05:53:16Z

 # newer versions go on top
+- version: "0.10.0"
+  changes:
+    - description: Fix intervals in the visualizations of Overview dashboard.


Suggested change

- description: Fix intervals in the visualizations of Overview dashboard.

- description: Fix intervals in the visualizations of the Overview dashboard.

Since, this is a bug fix, can we change version to 0.9.1 and type bugfix ?

Updated, thanks!

agithomas

LGTM!

elasticmachine · 2024-05-06T06:55:54Z

💚 Build Succeeded

Buildkite Build
Commit: 486f803

History

💚 Build #11082 succeeded 2562fc9
💚 Build #11042 succeeded 2d277b3
💚 Build #11010 succeeded cf9c9ce
💚 Build #10957 succeeded 3084f77
💚 Build #10955 succeeded 8828a658b862c6e1468784f648f5a17a9f7238a3
💚 Build #10092 succeeded 3084f77

cc @harnish-elastic

elastic-sonarqube · 2024-05-06T06:55:56Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elasticmachine · 2024-05-06T09:14:12Z

Package redisenterprise - 0.9.1 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

Fix aggregations, intervals and fields used in the visualizations of …

05580b7

…Overview dashboard

harnish-crest-data added the Integration:redisenterprise Redis Enterprise label Mar 28, 2024

harnish-crest-data self-assigned this Mar 28, 2024

update changelog.yml

ae16239

harnish-crest-data marked this pull request as ready for review March 28, 2024 06:34

harnish-crest-data requested a review from a team as a code owner March 28, 2024 06:34

harnish-crest-data requested a review from niraj-elastic March 28, 2024 06:44

niraj-elastic approved these changes Apr 1, 2024

View reviewed changes

devamanv added the enhancement New feature or request label Apr 2, 2024

agithomas reviewed Apr 2, 2024

View reviewed changes

address review comments

3084f77

harnish-crest-data requested a review from agithomas April 3, 2024 13:09

agithomas reviewed Apr 3, 2024

View reviewed changes

harnish-crest-data requested a review from agithomas April 5, 2024 06:00

harnish-crest-data requested a review from SubhrataK April 15, 2024 06:37

SubhrataK approved these changes Apr 16, 2024

View reviewed changes

elastic deleted a comment from cla-checker-service Bot Apr 30, 2024

ali786XI force-pushed the o11y-redis-enterprise-update-visualization branch from 8828a65 to 3084f77 Compare April 30, 2024 08:18

harnish-crest-data added 2 commits May 1, 2024 11:45

address review comments

132a7f0

add data_stream.dataset filter

cf9c9ce

agithomas reviewed May 1, 2024

View reviewed changes

harnish-crest-data changed the title ~~[O11y][Redis Enterprise] Fix aggregations, intervals and fields used in the visualizations of Overview dashboard~~ May 2, 2024

address review comments

2d277b3

harnish-crest-data requested a review from agithomas May 2, 2024 05:38

agithomas reviewed May 2, 2024

View reviewed changes

address review comments

2562fc9

harnish-crest-data requested a review from agithomas May 3, 2024 05:03

agithomas approved these changes May 3, 2024

View reviewed changes

update screenshot

486f803

harnish-crest-data merged commit 9dcc514 into elastic:main May 6, 2024

Navigation Menu

Uh oh!

[O11y][Redis Enterprise] Fix intervals in the visualizations of Overview dashboard - #9464

[O11y][Redis Enterprise] Fix intervals in the visualizations of Overview dashboard#9464
harnish-crest-data merged 8 commits into
elastic:mainfrom
chavdaharnish:o11y-redis-enterprise-update-visualization

harnish-crest-data commented Mar 28, 2024 •

edited

Loading

niraj-elastic left a comment

agithomas Apr 2, 2024

harnish-crest-data Apr 3, 2024

agithomas Apr 3, 2024

agithomas Apr 3, 2024

agithomas Apr 3, 2024

harnish-crest-data commented Apr 5, 2024 •

edited

Loading

agithomas commented Apr 20, 2024

agithomas commented Apr 20, 2024

agithomas May 1, 2024

harnish-crest-data May 2, 2024

agithomas May 2, 2024

agithomas May 2, 2024

harnish-crest-data May 3, 2024

agithomas left a comment

elasticmachine commented May 6, 2024

elastic-sonarqube Bot commented May 6, 2024

elasticmachine commented May 6, 2024

Labels

6 participants

	- description: Fix intervals in the visualizations of Overview dashboard.
	- description: Fix intervals in the visualizations of the Overview dashboard.

Uh oh!

Conversation

harnish-crest-data commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Related issues

Screenshots

Before

After

niraj-elastic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harnish-crest-data commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

agithomas commented Apr 20, 2024

agithomas commented Apr 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agithomas left a comment

Choose a reason for hiding this comment

elasticmachine commented May 6, 2024

💚 Build Succeeded

History

elastic-sonarqube Bot commented May 6, 2024

Quality Gate passed

elasticmachine commented May 6, 2024

Labels

6 participants

harnish-crest-data commented Mar 28, 2024 •

edited

Loading

harnish-crest-data commented Apr 5, 2024 •

edited

Loading