[akamai.siem] handle empty userRiskData strings - #9483
Merged
andrewkroh merged 2 commits intoApr 2, 2024
Conversation
Prevent the kv processor from executing on empty userRiskData.{risk,trust,general} values.
This aims to address these observed errors:
field [json.userRiskData.trust] does not contain value_split[:]
field [json.userRiskData.risk] does not contain value_split[:]
🚀 Benchmarks reportTo see the full report comment with |
[git-generate] cd packages/akamai elastic-package changelog add --link #9483 --next patch --type bugfix --description 'Fix errors processing empty userRiskData.{risk,trust,general} values.'
andrewkroh
marked this pull request as ready for review
April 1, 2024 22:23
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
History
|
|
efd6
approved these changes
Apr 2, 2024
efd6
left a comment
Contributor
There was a problem hiding this comment.
That is a surprising behaviour.
This is even more surprising.
POST /_ingest/pipeline/_simulate
{
"pipeline": {
"description": "_description",
"processors": [
{
"kv": {
"field": "foo",
"field_split": " ",
"value_split": "(=|$)"
}
}
]
},
"docs": [
{
"_index": "index",
"_id": "id",
"_source": {
"foo": "bar=one"
}
},
{
"_index": "index",
"_id": "id",
"_source": {
"foo": "rab"
}
},
{
"_index": "index",
"_id": "id",
"_source": {
"foo": ""
}
}
]
}
Contributor
Author
Agree. The behavior does not seem consistent. |
|
Package akamai - 2.23.1 containing this change is available at https://epr.elastic.co/search?package=akamai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

100.0% Coverage on New Code
0.0% Duplication on New Code
Proposed commit message
Prevent the kv processor from executing on empty
userRiskData.{risk,trust,general}values. This aims to address these observed errors:This is also improving on the
error.messageto help track down additional bugs.Checklist
changelog.ymlfile.