Skip to content

[akamai.siem] don't fail on headers without values - #9486

Merged
andrewkroh merged 4 commits into
elastic:mainfrom
andrewkroh:akamai/bugfix/header-no-value
Apr 3, 2024
Merged

[akamai.siem] don't fail on headers without values#9486
andrewkroh merged 4 commits into
elastic:mainfrom
andrewkroh:akamai/bugfix/header-no-value

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Make the kv processor not fail when it encounters an http header without a value (e.g. jsessionid:\r\n). In the value_split, this uses a regex to make the space after the colon optional.

Closes #9484

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@andrewkroh
akamai.siem - don't fail on headers without values
91a1742 
Make the kv processor not fail when it encounters an http header without a
value (e.g. `jsessionid:\r\n`). In the value_split, this uses a regex to make the
space after the colon optional.

Closes #9484
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Integration:akamai Akamai Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 2, 2024
@andrewkroh
add changelog
492bbda 
[git-generate]
cd akamai
elastic-package changelog add --link #9486 --next patch --type bugfix --description 'Handle HTTP headers without values.'
@andrewkroh
andrewkroh marked this pull request as ready for review April 2, 2024 03:35
@andrewkroh
andrewkroh requested a review from a team as a code owner April 2, 2024 03:35
@elasticmachine

elasticmachine commented Apr 2, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
efd6
efd6 reviewed Apr 2, 2024
View reviewed changes
Comment thread packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml Outdated
@andrewkroh @efd6
zero or more spaces
192d39d 
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
andrewkroh
andrewkroh commented Apr 2, 2024
View reviewed changes
Comment thread packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml Outdated
@elasticmachine

elasticmachine commented Apr 2, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Apr 2, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History
@elastic-sonarqube

elastic-sonarqube Bot commented Apr 2, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@andrewkroh
andrewkroh merged commit ba64324 into elastic:main Apr 3, 2024
@elasticmachine

elasticmachine commented Apr 3, 2024

Copy link
Copy Markdown

Package akamai - 2.23.2 containing this change is available at https://epr.elastic.co/search?package=akamai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:akamai Akamai Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@andrewkroh @elasticmachine @efd6