Microsoft Defender for Endpoint: Logstash compatibility. Remove message field if event.original exists - #9522
Merged
efd6 merged 4 commits intoApr 4, 2024
Conversation
In instances where the event.original field already exists, not specifically removing the message field breaks the rename processor where json.title is moved to the message field.
|
💚 CLA has been signed |
efd6
reviewed
Apr 4, 2024
efd6
left a comment
efd6
left a comment
Contributor
There was a problem hiding this comment.
Please add a changelog entry and bump the version in the manifest.
Contributor
Author
Done |
Contributor
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code
efd6
approved these changes
Apr 4, 2024
|
Package microsoft_defender_endpoint - 2.24.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint |
andrewkroh
added
the
Integration:microsoft_defender_endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In instances where the event.original field already exists when received by the ingest pipeline, such as when the sender is Logstash with ecs_compatibility set to either v1 or v8, not specifically removing the message field breaks the rename processor where
json.titleis moved to themessagefield.To solve that issue, this PR adds a separate remove processor that remove the
messagefield, if theevent.originalfield is present. This then allows the laterjson.titlerename processor to work.Checklist
changelog.ymlfile.