Skip to content

[OpenCanary] Beta Push of New Integration - #9532

Merged
efd6 merged 9 commits into
elastic:mainfrom
MakoWish:OpenCanary
Jun 6, 2024
Merged

[OpenCanary] Beta Push of New Integration#9532
efd6 merged 9 commits into
elastic:mainfrom
MakoWish:OpenCanary

Conversation

@MakoWish

@MakoWish MakoWish commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

Proposed commit message

This is a BETA version of a new Integration for ingesting events from OpenCanary HoneyPots.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Package has been tested locally

How to test this PR locally

elastic-package test -v

Related issues

None

Screenshots

None
@MakoWish MakoWish changed the title Initial commit of OpenCanary integration Apr 5, 2024
@MakoWish
MakoWish marked this pull request as ready for review April 5, 2024 17:48
@MakoWish

MakoWish commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

Pinging @efd6,

Would you mind taking a look at this one?
@jamiehynds jamiehynds added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Apr 12, 2024
@elasticmachine

elasticmachine commented Apr 12, 2024

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@jamiehynds jamiehynds added the New Integration Issue or pull request for creating a new integration package. label Apr 12, 2024
@botelastic

botelastic Bot commented May 12, 2024

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic Bot added the Stalled label May 12, 2024
@botelastic botelastic Bot removed the Stalled label May 28, 2024
@andrewkroh andrewkroh added the Integration:opencanary OpenCanary (Community supported) label May 30, 2024
@andrewkroh
andrewkroh requested a review from a team May 30, 2024 14:21
@efd6

efd6 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

/test
efd6
efd6 reviewed Jun 3, 2024
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs addition to CODEOWNERS; add as /packages/opencanary @elastic/security-service-integrations

Error: there is no owner for "packages/opencanary" in ".github/CODEOWNERS"
Comment thread packages/opencanary/_dev/deploy/docker/sample_logs/events.log
Comment thread packages/opencanary/data_stream/events/agent/stream/stream.yml.hbs Outdated
Comment thread packages/opencanary/data_stream/events/agent/stream/stream.yml.hbs Outdated
Comment thread packages/opencanary/data_stream/events/fields/fields.yml Outdated
Comment thread packages/opencanary/data_stream/events/sample_event.json
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml Outdated
@efd6

efd6 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Jun 3, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@efd6

efd6 commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Needs an elastic-package build.
efd6
efd6 reviewed Jun 5, 2024
View reviewed changes
Comment thread packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml Outdated
@MakoWish

MakoWish commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

Needs an elastic-package build.

Done.
@efd6

efd6 commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

One last outstanding issue (hidden in the fold). https://github.com/elastic/integrations/pull/9532/files#r1623714579
@efd6

efd6 commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

/test
@elastic-sonarqube

elastic-sonarqube Bot commented Jun 6, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Jun 6, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History
efd6
efd6 approved these changes Jun 6, 2024
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6
efd6 merged commit 75cea12 into elastic:main Jun 6, 2024
@elasticmachine

elasticmachine commented Jun 6, 2024

Copy link
Copy Markdown

Package opencanary - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=opencanary
@MakoWish
MakoWish deleted the OpenCanary branch June 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:opencanary OpenCanary (Community supported) New Integration Issue or pull request for creating a new integration package. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants

@MakoWish @elasticmachine @efd6 @andrewkroh @jamiehynds