Skip to content

[cisco_nexus]: remove redundant nested repeat operator - #9570

Merged
pkoutsovasilis merged 1 commit into
mainfrom
pkoutsovasilis/fix_cisco_nexus_warnings
Apr 15, 2024
Merged

[cisco_nexus]: remove redundant nested repeat operator#9570
pkoutsovasilis merged 1 commit into
mainfrom
pkoutsovasilis/fix_cisco_nexus_warnings

Conversation

@pkoutsovasilis

Copy link
Copy Markdown
Contributor

Proposed commit message

After tackling this issue, a respective PR was created to elastic-package to mainstream the detection of similar warnings. Thus this PR fixes the following similar to the former issue regex-related warning for cisco_nexus

detected ingest pipeline warnings: 1: regular expression has redundant nested repeat operator * /(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?) is up in mode (?<DATA:cisco_nexus.log.interface.mode>.*?)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?) is (?:.*)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?), operational speed changed to (?<DATA:cisco_nexus.log.operational.speed>.*?)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?), operational duplex mode changed to (?<DATA:cisco_nexus.log.operational.duplex_mode>.*?)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?), operational Receive Flow Control state changed to (?<DATA:cisco_nexus.log.operational.receive_flow_control_state>.*?)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?), operational Transmit Flow Control state changed to (?<DATA:cisco_nexus.log.operational.transmit_flow_control_state>.*?)$)|(?:^(?:(?:.*)(?:\s*)?(?i)interface)(?:\s*)(?<DATA:cisco_nexus.log.interface.name>.*?), (?:.*)$)/

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

Related issues

N/A

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis added bug Something isn't working, use only for issues Integration:cisco_nexus Cisco Nexus Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 11, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Apr 11, 2024
@pkoutsovasilis
pkoutsovasilis force-pushed the pkoutsovasilis/fix_cisco_nexus_warnings branch from b6678d4 to 0402913 Compare April 11, 2024 10:23
@pkoutsovasilis
pkoutsovasilis marked this pull request as ready for review April 11, 2024 10:23
@pkoutsovasilis
pkoutsovasilis requested a review from a team as a code owner April 11, 2024 10:23
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine

elasticmachine commented Apr 11, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jrmolin jrmolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@dwhyrock

Copy link
Copy Markdown
Contributor
Data stream Previous EPS New EPS Diff (%) Result
log 1697.79 1275.51 -422.28 (-24.87%) 💔

Do we need to be concerned about the performance report?

@pkoutsovasilis

Copy link
Copy Markdown
Contributor Author

/test benchmark fullreport

@pkoutsovasilis
pkoutsovasilis force-pushed the pkoutsovasilis/fix_cisco_nexus_warnings branch from 2d4c1ab to 05295cf Compare April 15, 2024 07:55
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #10412 succeeded 2d4c1abb4c25f4b439e0743279e2b82552926de6
  • 💚 Build #10357 succeeded 04029135137b1a4ec346c711ec59924683c5dac2
  • 💚 Build #10353 succeeded 04029135137b1a4ec346c711ec59924683c5dac2

cc @pkoutsovasilis

@elastic-sonarqube

Copy link
Copy Markdown
@pkoutsovasilis
pkoutsovasilis merged commit c3da38d into main Apr 15, 2024
@pkoutsovasilis
pkoutsovasilis deleted the pkoutsovasilis/fix_cisco_nexus_warnings branch April 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_nexus Cisco Nexus Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants