Skip to content

Consolidate content on the Azure Container Instance Metrics doc page - #9611

Merged
alaudazzi merged 12 commits into
elastic:mainfrom
alaudazzi:fix-324-332-instance
Apr 22, 2024
Merged

Consolidate content on the Azure Container Instance Metrics doc page#9611
alaudazzi merged 12 commits into
elastic:mainfrom
alaudazzi:fix-324-332-instance

Conversation

@alaudazzi

Copy link
Copy Markdown
Contributor

Proposed commit message

On the Azure Container Instance Metrics, this PR:

  • Removes duplicate and confusing content related to Kibana configurations, authentication, and costs.
  • Replaces this content with references to generic instructions clearly documented on the Azure Resource Metrics page.
  • Adds the Requirements and Setup sections to comply with the documentation guidelines.

Related issues

@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement labels Apr 16, 2024
@alaudazzi
alaudazzi requested review from muthu-mps and zmoog April 16, 2024 12:33
@alaudazzi
alaudazzi requested a review from a team as a code owner April 16, 2024 12:33
@elasticmachine

elasticmachine commented Apr 16, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

Package azure_metrics 👍(1) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
container_instance 200000 15384.62 -184615.38 (-92.31%) 💔

To see the full report comment with /test benchmark fullreport

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I suggested a super-minor changes to capitalization. Is this the correct way to capitalize?

Comment thread packages/azure_metrics/docs/container_instance.md Outdated
Comment thread packages/azure_metrics/docs/container_instance.md Outdated
alaudazzi and others added 2 commits April 17, 2024 13:33
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
@alaudazzi

Copy link
Copy Markdown
Contributor Author

Thank you @zmoog good catch!

Comment thread packages/azure_metrics/_dev/build/docs/container_instance.md Outdated
@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@alaudazzi
alaudazzi merged commit 800a038 into elastic:main Apr 22, 2024
@elasticmachine

Copy link
Copy Markdown

Package azure_metrics - 1.6.3 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement Integration:azure_metrics Azure Resource Metrics

5 participants