Skip to content

[panw] Allow apostrophes in usernames - #9635

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:bug/panw-email
Apr 17, 2024
Merged

[panw] Allow apostrophes in usernames#9635
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:bug/panw-email

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Apr 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Add apostrophe to the character set for username/email groks
  • Add test case

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/panw
elastic-package test

Related issues

  • Relates elastic/sdh-beats#4623
@taylor-swanson
[panw] Allow apostrophes in usernames
96eee42 
- Add apostrophe to the character set for username/email groks
- Add test case
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 17, 2024
@taylor-swanson taylor-swanson self-assigned this Apr 17, 2024
@elasticmachine

elasticmachine commented Apr 17, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Apr 17, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Apr 17, 2024

Copy link
Copy Markdown

💚 Build Succeeded

cc @taylor-swanson
@taylor-swanson
taylor-swanson marked this pull request as ready for review April 17, 2024 14:23
@taylor-swanson
taylor-swanson requested a review from a team as a code owner April 17, 2024 14:24
@elasticmachine

elasticmachine commented Apr 17, 2024

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)
@taylor-swanson
taylor-swanson merged commit c92acc3 into elastic:main Apr 17, 2024
@taylor-swanson
taylor-swanson deleted the bug/panw-email branch April 17, 2024 14:50
@elasticmachine

elasticmachine commented Apr 17, 2024

Copy link
Copy Markdown

Package panw - 3.24.3 containing this change is available at https://epr.elastic.co/search?package=panw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants

@taylor-swanson @elasticmachine @pkoutsovasilis