Skip to content

Consolidate content on Azure metrics pages - #9674

Merged
alaudazzi merged 6 commits into
elastic:mainfrom
alaudazzi:fix-324-332-azure-metrics
Apr 23, 2024
Merged

Consolidate content on Azure metrics pages#9674
alaudazzi merged 6 commits into
elastic:mainfrom
alaudazzi:fix-324-332-azure-metrics

Conversation

@alaudazzi

Copy link
Copy Markdown
Contributor

Proposed commit message

This PR:

  • Removes duplicate and confusing content related to Kibana configurations, authentication, and costs.
  • Adds references to generic instructions documented on the Azure Resource Metrics page.
  • Adds the Requirements and Setup sections to comply with the documentation guidelines.
  • Fixes product names and capitalization

The doc updates impact the following Azure doc pages:

Related issues

@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement labels Apr 23, 2024
@alaudazzi
alaudazzi requested review from muthu-mps and zmoog April 23, 2024 08:46
@alaudazzi
alaudazzi requested a review from a team as a code owner April 23, 2024 08:46
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only added a couple of capitalization suggestions.

Comment thread packages/azure_metrics/_dev/build/docs/container_registry.md Outdated
Comment thread packages/azure_metrics/docs/container_registry.md Outdated
Comment thread packages/azure_metrics/_dev/build/docs/database_account.md Outdated
Comment thread packages/azure_metrics/docs/database_account.md Outdated
@zmoog

zmoog commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

LGTM, I only added a couple of capitalization suggestions.

This time, I updated both docs sources and renders, so it should not break the build 🤞

alaudazzi and others added 4 commits April 23, 2024 16:20
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@alaudazzi
alaudazzi merged commit 328838e into elastic:main Apr 23, 2024
@elasticmachine

Copy link
Copy Markdown

Package azure_metrics - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

gizas pushed a commit that referenced this pull request Apr 26, 2024
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement Integration:azure_metrics Azure Resource Metrics

5 participants