Conversation
gogochan
marked this pull request as ready for review
April 23, 2024 16:15
gogochan
added
Integration:panw
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
taylor-swanson
approved these changes
Apr 23, 2024
taylor-swanson
left a comment
taylor-swanson
left a comment
Contributor
There was a problem hiding this comment.
LGTM
title nit: The name of integration is panw, not panos (which is the data stream name).
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
|
Package panw - 3.24.4 containing this change is available at https://epr.elastic.co/search?package=panw |
gizas
pushed a commit
that referenced
this pull request
Apr 26, 2024
qcorporation
pushed a commit
that referenced
this pull request
Feb 3, 2025
qcorporation
pushed a commit
that referenced
this pull request
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Link to SDH
This PR allows url to not have
/, allowing something likeelastic.co. The painless script that handles url had a condition for a mandatory/in url field. Due to this condition, any urls not containing/were not processed by this painless script, resulting in missing field as noted in the SDH.The logic was updated and the script was updated to handle both URL with or without
/.There was also another bug in port number parsing, making url.port string instead of long as defined HERE. Let me know if this fix breaks existing deployment because of this change.
Checklist
changelog.ymlfile.How to test this PR locally
elastic-package testRelated issues
Screenshots