Skip to content

[Postgresql] Add alias field for database.oid - #9695

Merged
milan-elastic merged 4 commits into
elastic:mainfrom
niraj-elastic:postgresql_alias_field
May 2, 2024
Merged

[Postgresql] Add alias field for database.oid#9695
milan-elastic merged 4 commits into
elastic:mainfrom
niraj-elastic:postgresql_alias_field

Conversation

@niraj-elastic

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

There are 3 datasets in Postgresql and all three have OID fields under different field names.

  • postgresql.activity.database.oid
  • postgresql.database.oid
  • postgresql.statement.database.oid

User should be able to associate data across these 3 datasets using these OID's.

To solve this issue we have added database.oid field as alias fild to all the above fields

Related issue

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@niraj-elastic
niraj-elastic requested a review from a team as a code owner April 24, 2024 09:40

@milan-elastic milan-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can use field aliasing here.
Alias all these 3 fields in datastream to database.oid.

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@milan-elastic
milan-elastic merged commit 61f2326 into elastic:main May 2, 2024
@elasticmachine

Copy link
Copy Markdown

Package postgresql - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=postgresql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants