Skip to content

[Azure] [Audit Logs] Update Azure Audit Logs pipeline with support for initiated_by user fields - #9701

Merged
lucian-ioan merged 10 commits into
elastic:mainfrom
lucian-ioan:azure_auditlogs_add_additional_field
May 1, 2024
Merged

[Azure] [Audit Logs] Update Azure Audit Logs pipeline with support for initiated_by user fields#9701
lucian-ioan merged 10 commits into
elastic:mainfrom
lucian-ioan:azure_auditlogs_add_additional_field

Conversation

@lucian-ioan

@lucian-ioan lucian-ioan commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Update Azure Audit Logs pipeline with support for initiated_by user fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

These fields are currently not supported by the pipeline:
286950041-1a0bb221-d865-48c6-98c9-5c327c7032ec

@lucian-ioan
lucian-ioan marked this pull request as ready for review April 24, 2024 15:30
@lucian-ioan
lucian-ioan requested review from a team as code owners April 24, 2024 15:30
@elasticmachine

elasticmachine commented Apr 24, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

ignore_missing: true
- rename:
field: azure.auditlogs.properties.resultDescription
target_field: azure.auditlogs.properties.result_description

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result_description field isn't there in the fields.yml. Including this field to the pipeline test would help to trace the missing fields.

@lucian-ioan
lucian-ioan requested a review from muthu-mps April 29, 2024 08:46

@muthu-mps muthu-mps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

"correlation_id": "8a4de8b5-095c-47d0-a96f-a75130c61d53",
"id": "Directory_ESQ",
"initiated_by": {
"user": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fields inside initiated_by doesn't apply the naming standard but the rest of the fields does in audit logs. This is existing and not relevant to this PR. Lets figure out a way to address this issue.

@muthu-mps muthu-mps changed the title [Azure] [Audit Logs] Update Azure Audit Logs pipeline with support for more fields Apr 30, 2024
@lucian-ioan
lucian-ioan enabled auto-merge (squash) May 1, 2024 21:19
@lucian-ioan
lucian-ioan merged commit 6e5b929 into elastic:main May 1, 2024
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @lucian-ioan

@elasticmachine

Copy link
Copy Markdown

Package azure - 1.11.3 containing this change is available at https://epr.elastic.co/search?package=azure

@lucian-ioan
lucian-ioan deleted the azure_auditlogs_add_additional_field branch February 6, 2025 19:11
shmsr added a commit to shmsr/integrations that referenced this pull request Jul 20, 2026
…test

PR elastic#9701 added a pipeline rename for properties.resultDescription →
properties.result_description but never declared the field in fields.yml
or added test coverage. This adds both:

- fields.yml: declare properties.result_description as keyword/8191
- adlogs.md: add the field to the docs table
- test fixture: second event in test-auditlogs-result-description.log
  exercises the properties rename end-to-end

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants