Skip to content

[eset_protect][imperva_cloud_waf][sentinal_one_cloud_funnel][ti_crowdstrike] Use modern ecs@mappings - #9778

Merged
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:modern-ecs-mappings
May 3, 2024
Merged

[eset_protect][imperva_cloud_waf][sentinal_one_cloud_funnel][ti_crowdstrike] Use modern ecs@mappings#9778
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:modern-ecs-mappings

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented May 3, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

[eset_protect][imperva_cloud_waf][sentinal_one_cloud_funnel][ti_crowdstrike] Use modern ecs@mappings (#)

- Remove `dependencies.ecs.import_mappings: true`.
- Set `8.13` as the minimum stack version.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added enhancement New feature or request Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:eset_protect ESET PROTECT Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:imperva_cloud_waf Imperva Cloud WAF labels May 3, 2024
@chrisberkhout chrisberkhout self-assigned this May 3, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner May 3, 2024 06:21
@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label May 3, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chrisberkhout chrisberkhout mentioned this pull request May 3, 2024
4 tasks
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @chrisberkhout

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisberkhout
chrisberkhout merged commit ae85e39 into elastic:main May 3, 2024
@chrisberkhout
chrisberkhout deleted the modern-ecs-mappings branch May 3, 2024 08:30
@elasticmachine

Copy link
Copy Markdown

Package eset_protect - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=eset_protect

@elasticmachine

Copy link
Copy Markdown

Package imperva_cloud_waf - 0.3.1 containing this change is available at https://epr.elastic.co/search?package=imperva_cloud_waf

@elasticmachine

Copy link
Copy Markdown

Package sentinel_one_cloud_funnel - 0.14.2 containing this change is available at https://epr.elastic.co/search?package=sentinel_one_cloud_funnel

@elasticmachine

Copy link
Copy Markdown

Package ti_crowdstrike - 0.5.5 containing this change is available at https://epr.elastic.co/search?package=ti_crowdstrike

@andrewkroh

Copy link
Copy Markdown
Contributor

@chrisberkhout For future reference, you probably want a shorter git commit summary line. The summary of this commit was truncated.

https://kortschak.io/courses/git_workshop/communication/#commit-messages

@joshFive

Copy link
Copy Markdown

Should this release also have the kibana 8.13.0 requirement added on the download page?

@chrisberkhout

Copy link
Copy Markdown
Contributor Author

Hi @joshFive,

The updated metadata will show up, for example here you'll see "Compatible Kibana version(s): 8.13.0 or higher".

However, I noticed that all of these integrations had a hard-coded Kibana version number mentioned in the README. I've opened a PR to remove those so that the version constraints are in one place only, as we have it for many other integrations: #10182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:eset_protect ESET PROTECT Integration:imperva_cloud_waf Imperva Cloud WAF Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants