m365_defender: use windows-specific command line analyser - #9812
Merged
Conversation
efd6
added
enhancement
🚀 Benchmarks reportTo see the full report comment with |
efd6
marked this pull request as ready for review
May 8, 2024 00:38
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
The previous analyser was not quote aware and so resulted in mis-constructed argument lists, resulting in missed detection rule. The inputs to the integration are likely to be entirely from windows hosts, so use the windows-specific analyser from the crowdstrike fdr data stream.
💚 Build Succeeded
History
cc @efd6 |
|
chrisberkhout
approved these changes
May 16, 2024
Contributor
Author
|
I'm wondering if that isn't a corrupted hand-crafted test input. |
Contributor
|
Correction to my earlier commit: the result is a single argument, not 3.
Could be. |
|
Package m365_defender - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The previous analyser was not quote aware and so resulted in mis-constructed argument lists, resulting in missed detection rule.
The inputs to the integration are likely to be entirely from windows hosts, so use the windows-specific analyser from the crowdstrike fdr data stream.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots