Skip to content

[Cloud Security] add the cloud formation credentials url - #9828

Merged
Omolola-Akinleye merged 3 commits into
elastic:mainfrom
Omolola-Akinleye:cloud_credentials
May 14, 2024
Merged

[Cloud Security] add the cloud formation credentials url#9828
Omolola-Akinleye merged 3 commits into
elastic:mainfrom
Omolola-Akinleye:cloud_credentials

Conversation

@Omolola-Akinleye

@Omolola-Akinleye Omolola-Akinleye commented May 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Add cloud formation credentials template url which help users create stack to automate direct access keys to copy and paste to input fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image
@Omolola-Akinleye Omolola-Akinleye self-assigned this May 9, 2024
@Omolola-Akinleye
Omolola-Akinleye requested a review from a team as a code owner May 9, 2024 21:55
@elasticmachine

elasticmachine commented May 9, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
seanrathier
seanrathier approved these changes May 10, 2024
View reviewed changes

@seanrathier seanrathier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of comments
Comment thread packages/cloud_security_posture/manifest.yml Outdated
multi: false
required: true
show_user: false
description: Template URL to create cloud credentials to Create Stack

@seanrathier seanrathier May 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Template URL to create cloud credentials for Create Stack"

@Omolola-Akinleye Omolola-Akinleye May 13, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to Template URL to Cloud Formation Cloud Credentials Stack similar description structure to Template URL to Cloud Formation Quick Create Stack
Comment thread packages/cloud_security_posture/manifest.yml Outdated
show_user: false
description: Template URL to create cloud credentials to Create Stack
# ACCOUNT_TYPE value should be either "single-account" or "organization-account"
default: https://console.aws.amazon.com/cloudformation/home#/stacks/quickcreate?templateURL=https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-cspm-direct-access-key-ACCOUNT-TYPE-8.14.0.yml

@seanrathier seanrathier May 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be version 8.15.0.yml?

@Omolola-Akinleye Omolola-Akinleye May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @seanrathier once this PR I will change version to 8.15.0
@kfirpeled kfirpeled linked an issue May 12, 2024 that may be closed by this pull request
[Cloud Security] Automated creation of cloud credentials elastic/kibana#175977
Closed
2 tasks
@orouz

orouz commented May 13, 2024

Copy link
Copy Markdown
Contributor

@Omolola-Akinleye

i talked to @maxcold about this a while ago and i think if it's possible to just store these values in kibana that'd be preferable
orestisfl
orestisfl requested changes May 13, 2024
View reviewed changes
Comment thread packages/cloud_security_posture/manifest.yml Outdated
@Omolola-Akinleye

Omolola-Akinleye commented May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Omolola-Akinleye

i talked to @maxcold about this a while ago and i think if it's possible to just store these values in kibana that'd be preferable

Hey @orouz I missing some context. Would you remind me why we want to store these values in Kibana? I discussed with @kfirpeled and we decided to use Integration so when the package version is being upgraded along with the template url version will be upgraded.

Also, @orouz @oren-zohar Does the Go version change align with Kibana upgrades or downgrades? Before the merge, I encountered Access Denied error when my kibana version is 8.15.0 and the hardcoded template url (https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-cspm-direct-access-key-ACCOUNT-TYPE-8.15.0.yml` ). This could be a potential issue with maintain version on Kibana side.
@elasticmachine

elasticmachine commented May 13, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @Omolola-Akinleye
@elastic-sonarqube

elastic-sonarqube Bot commented May 13, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@oren-zohar

oren-zohar commented May 13, 2024

Copy link
Copy Markdown
Contributor

@Omolola-Akinleye I think @orouz raise an interesting point and we should discuss it offline, but it's out of this PR scope, so feel free to merge if you think it's ready
@Omolola-Akinleye

Omolola-Akinleye commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

@Omolola-Akinleye I think @orouz raise an interesting point and we should discuss it offline, but it's out of this PR scope, so feel free to merge if you think it's ready

Thanks @oren-zohar @orouz I'll merge for now, and create a thread to discuss offline
@Omolola-Akinleye
Omolola-Akinleye merged commit 436116d into elastic:main May 14, 2024
@elasticmachine

elasticmachine commented May 14, 2024

Copy link
Copy Markdown

Package cloud_security_posture - 1.10.0-preview01 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
@elasticmachine

elasticmachine commented May 30, 2024

Copy link
Copy Markdown

Package cloud_asset_inventory - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory
@elasticmachine

elasticmachine commented May 31, 2024

Copy link
Copy Markdown

Package cloud_asset_inventory - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory
@elasticmachine

elasticmachine commented Jun 7, 2024

Copy link
Copy Markdown

Package cloud_asset_inventory - 0.1.2 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory
@elasticmachine

elasticmachine commented Jun 25, 2024

Copy link
Copy Markdown

Package cloud_asset_inventory - 0.1.4 containing this change is available at https://epr.elastic.co/search?package=cloud_asset_inventory
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
@elasticmachine

elasticmachine commented Jul 31, 2024

Copy link
Copy Markdown

Package cloud_security_posture - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.15 candidate enhancement New feature or request Integration:cloud_security_posture Security Posture Management

7 participants

@Omolola-Akinleye @elasticmachine @orouz @oren-zohar @seanrathier @orestisfl @andrewkroh