Skip to content

[O11y][HAProxy] Enable secret for the password field, update format version and add dashboard-level filters. - #9897

Merged
harnish-crest-data merged 4 commits into
elastic:mainfrom
chavdaharnish:enable-secret-for-haproxy
Jun 6, 2024
Merged

[O11y][HAProxy] Enable secret for the password field, update format version and add dashboard-level filters.#9897
harnish-crest-data merged 4 commits into
elastic:mainfrom
chavdaharnish:enable-secret-for-haproxy

Conversation

@harnish-crest-data

@harnish-crest-data harnish-crest-data commented May 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

Proposed commit message

  • Update format version to 3.0.2.
  • Update kibana version to 8.12.0.
  • Inline "by reference" visualizations.
  • Added dashboard level filters.
  • Enable secrets for sensitive fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

HAProxy
Backend Before Backend After
haproxy backend-before haproxy backend-after
Frontend Before Frontend After
haproxy frontend-before haproxy frontend-after
HTTP backend Before HTTP backend After
haproxy http backend-before haproxy http backend-after
HTTP frontend Before HTTP frontend After
haproxy http frontend - before haproxy http frontend - after
HTTP server Before HTTP server After
haproxy http server - before haproxy http server - after
Log overview Before Log overview After
haproxy logs overview - before haproxy logs overview - after
@harnish-crest-data harnish-crest-data added the enhancement New feature or request label May 16, 2024
@harnish-crest-data harnish-crest-data self-assigned this May 16, 2024
@elasticmachine

elasticmachine commented May 16, 2024 •
edited
Loading

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@harnish-crest-data
harnish-crest-data marked this pull request as ready for review May 17, 2024 06:17
@harnish-crest-data
harnish-crest-data requested a review from a team as a code owner May 17, 2024 06:17
@ritalwar

ritalwar commented May 27, 2024

Copy link
Copy Markdown
Contributor

Can you add screenshots for the filter-related changes?
ritalwar
ritalwar reviewed May 27, 2024
View reviewed changes
Comment thread packages/haproxy/manifest.yml Outdated
type: image/svg+xml
format_version: 1.0.0
license: basic
format_version: 3.0.0

@ritalwar ritalwar May 27, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format version should be upgraded to 3.0.2 for secret enablement change.
ritalwar
ritalwar reviewed May 27, 2024
View reviewed changes
Comment thread packages/haproxy/changelog.yml Outdated
# newer versions go on top
- version: "1.12.0"
changes:
- description: Update format version and enable secrets for sensitive fields. For more details, refer https://www.elastic.co/guide/en/fleet/current/agent-policy.html#agent-policy-secret-values

@ritalwar ritalwar May 27, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Update format version and enable secrets for sensitive fields. For more details, refer https://www.elastic.co/guide/en/fleet/current/agent-policy.html#agent-policy-secret-values
- description: Enable secret for the `password` field and add dashboard-level filters.

We don't need to add the link here since it's already shown in Kibana, but I'm okay with keeping it if you prefer. We didn't do this in other secret enablement PRs.
@harnish-crest-data

harnish-crest-data commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

Can you add screenshots for the filter-related changes?

It is already present in the screenshot section of the description.
@elasticmachine

elasticmachine commented May 28, 2024

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @harnish-elastic
@elastic-sonarqube

elastic-sonarqube Bot commented May 28, 2024

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@ritalwar ritalwar changed the title [O11y][HAProxy] Update format version and enable secrets for sensitive fields May 28, 2024
kush-elastic
kush-elastic approved these changes May 30, 2024
View reviewed changes

@kush-elastic kush-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@harnish-crest-data
harnish-crest-data merged commit 433b6cc into elastic:main Jun 6, 2024
@elasticmachine

elasticmachine commented Jun 6, 2024

Copy link
Copy Markdown

Package haproxy - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=haproxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:haproxy HAProxy

6 participants

@harnish-crest-data @elasticmachine @ritalwar @devamanv @kush-elastic @andrewkroh