[GCP] [Billing] Improve documentation - #9931
Merged
15 commits merged intoAug 12, 2024
Merged
Conversation
ghost
self-assigned this
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
2192.98 | 1692.05 | -500.93 (-22.84%) | 💔 |
dns |
3030.3 | 2237.14 | -793.16 (-26.17%) | 💔 |
vpcflow |
3984.06 | 3344.48 | -639.58 (-16.05%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
ghost
marked this pull request as ready for review
May 21, 2024 20:25
shmsr
requested changes
May 22, 2024
ishleenk17
reviewed
May 27, 2024
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Linu-Elias
approved these changes
Aug 5, 2024
shmsr
approved these changes
Aug 6, 2024
alaudazzi
approved these changes
Aug 12, 2024
alaudazzi
left a comment
alaudazzi
left a comment
Contributor
There was a problem hiding this comment.
Left a few minor editing suggestions, otherwise LGTM.
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
💚 Build Succeeded
History
cc @gpop63 |
|
|
Package gcp - 2.37.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* improve docs * bump package version * fix pr id * add cost_type in docs * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * address reviews * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update packages/gcp/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * remove newline --------- Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* improve docs * bump package version * fix pr id * add cost_type in docs * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * address reviews * Update packages/gcp/_dev/build/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update packages/gcp/docs/billing.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * remove newline --------- Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improves GCP Billing documentation to clarify what each config param means.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots